Bug 18625 – SQUIRRELFISH: squirrelfish needs to support JS debugging

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Maciej Stachowiak]

SquirrelFish currently does not support the debug interfaces that are present in trunk. We will need to fix JS debugging to be able to merge to trunk

[Geoffrey Garen]

I'll take this one.

[Geoffrey Garen]

Created attachment 21213 [details]
patch

you love it

[Oliver Hunt]

Comment on attachment 21213 [details]
patch

You need to do this on windows as well :D

[Geoffrey Garen]

Nah, the windows code is gone from TOT. We can just rip it out.

[Geoffrey Garen]

Committed revision 33553.

[Oliver Hunt]

Patch is incomplete, in bugzilla so can't fix build :-(

Reverted in r33560

[Oliver Hunt]

Comment on attachment 21213 [details]
patch

This patch is "good" but the missing files  need to be reviewed before they can be landed.

I'm leaving r+ because this portion of the patch is fine.

Oh, except the changelog should include the bug# and url :D

[Geoffrey Garen]

Created attachment 21219 [details]
missing files from original patch

[Oliver Hunt]

Comment on attachment 21219 [details]
missing files from original patch

Woo!!!

Why aren't you on irc? :p

[Oliver Hunt]

Committing to http://svn.webkit.org/repository/webkit/branches/squirrelfish ...
	C	WebKit/mac/WebView/WebScriptDebugger.h => JavaScriptCore/kjs/DebuggerCallFrame.h
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/JavaScriptCore.exp
	M	JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
	M	JavaScriptCore/VM/CodeGenerator.cpp
	M	JavaScriptCore/VM/CodeGenerator.h
	M	JavaScriptCore/VM/Machine.cpp
	M	JavaScriptCore/VM/Machine.h
	A	JavaScriptCore/kjs/DebuggerCallFrame.cpp
	M	JavaScriptCore/kjs/ExecState.h
	M	JavaScriptCore/kjs/debugger.cpp
	M	JavaScriptCore/kjs/debugger.h
	M	JavaScriptCore/kjs/function.cpp
	M	JavaScriptCore/kjs/nodes.cpp
	M	WebCore/ChangeLog
	A	WebCore/ForwardingHeaders/kjs/DebuggerCallFrame.h
	M	WebCore/page/InspectorController.cpp
	M	WebCore/page/InspectorController.h
	M	WebCore/page/JavaScriptDebugListener.h
	M	WebCore/page/JavaScriptDebugServer.cpp
	M	WebCore/page/JavaScriptDebugServer.h
	M	WebKit/mac/ChangeLog
	A	WebKit/mac/ForwardingHeaders/kjs/DebuggerCallFrame.h
	M	WebKit/mac/WebView/WebScriptDebugDelegate.mm
	M	WebKit/mac/WebView/WebScriptDebugger.h
	M	WebKit/mac/WebView/WebScriptDebugger.mm
Committed r33563