Bug 18625 - SQUIRRELFISH: squirrelfish needs to support JS debugging
Summary: SQUIRRELFISH: squirrelfish needs to support JS debugging
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Geoffrey Garen
Depends on:
Reported: 2008-04-19 14:36 PDT by Maciej Stachowiak
Modified: 2008-05-18 01:50 PDT (History)
1 user (show)

See Also:

patch (58.36 KB, patch)
2008-05-17 01:50 PDT, Geoffrey Garen
oliver: review+
Details | Formatted Diff | Diff
missing files from original patch (6.43 KB, patch)
2008-05-18 00:41 PDT, Geoffrey Garen
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2008-04-19 14:36:07 PDT
SquirrelFish currently does not support the debug interfaces that are present in trunk. We will need to fix JS debugging to be able to merge to trunk
Comment 1 Geoffrey Garen 2008-05-06 18:44:58 PDT
I'll take this one.
Comment 2 Geoffrey Garen 2008-05-17 01:50:36 PDT
Created attachment 21213 [details]

you love it
Comment 3 Oliver Hunt 2008-05-17 03:49:00 PDT
Comment on attachment 21213 [details]

You need to do this on windows as well :D
Comment 4 Geoffrey Garen 2008-05-17 11:47:38 PDT
Nah, the windows code is gone from TOT. We can just rip it out.
Comment 5 Geoffrey Garen 2008-05-17 11:58:49 PDT
Committed revision 33553.

Comment 6 Oliver Hunt 2008-05-17 20:01:53 PDT
Patch is incomplete, in bugzilla so can't fix build :-(

Reverted in r33560
Comment 7 Oliver Hunt 2008-05-17 20:04:02 PDT
Comment on attachment 21213 [details]

This patch is "good" but the missing files  need to be reviewed before they can be landed.

I'm leaving r+ because this portion of the patch is fine.

Oh, except the changelog should include the bug# and url :D
Comment 8 Geoffrey Garen 2008-05-18 00:41:26 PDT
Created attachment 21219 [details]
missing files from original patch
Comment 9 Oliver Hunt 2008-05-18 00:44:23 PDT
Comment on attachment 21219 [details]
missing files from original patch


Why aren't you on irc? :p
Comment 10 Oliver Hunt 2008-05-18 01:50:05 PDT
Committing to http://svn.webkit.org/repository/webkit/branches/squirrelfish ...
	C	WebKit/mac/WebView/WebScriptDebugger.h => JavaScriptCore/kjs/DebuggerCallFrame.h
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/JavaScriptCore.exp
	M	JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
	M	JavaScriptCore/VM/CodeGenerator.cpp
	M	JavaScriptCore/VM/CodeGenerator.h
	M	JavaScriptCore/VM/Machine.cpp
	M	JavaScriptCore/VM/Machine.h
	A	JavaScriptCore/kjs/DebuggerCallFrame.cpp
	M	JavaScriptCore/kjs/ExecState.h
	M	JavaScriptCore/kjs/debugger.cpp
	M	JavaScriptCore/kjs/debugger.h
	M	JavaScriptCore/kjs/function.cpp
	M	JavaScriptCore/kjs/nodes.cpp
	M	WebCore/ChangeLog
	A	WebCore/ForwardingHeaders/kjs/DebuggerCallFrame.h
	M	WebCore/page/InspectorController.cpp
	M	WebCore/page/InspectorController.h
	M	WebCore/page/JavaScriptDebugListener.h
	M	WebCore/page/JavaScriptDebugServer.cpp
	M	WebCore/page/JavaScriptDebugServer.h
	M	WebKit/mac/ChangeLog
	A	WebKit/mac/ForwardingHeaders/kjs/DebuggerCallFrame.h
	M	WebKit/mac/WebView/WebScriptDebugDelegate.mm
	M	WebKit/mac/WebView/WebScriptDebugger.h
	M	WebKit/mac/WebView/WebScriptDebugger.mm
Committed r33563