186239 – Update Strong Password appearance

Bug 186239 - Update Strong Password appearance

Summary: Update Strong Password appearance

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Layout and Rendering (show other bugs)
Version:	WebKit Local Build
Hardware:	Mac macOS 10.13

Importance:	P2 Normal
Assignee:	Daniel Bates

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2018-06-02 15:31 PDT by Daniel Bates
Modified:	2018-06-04 14:29 PDT (History)
CC List:	5 users (show)

See Also:

Attachments
For EWS (12.74 KB, patch) 2018-06-02 15:34 PDT, Daniel Bates	no flags	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (2.33 MB, application/zip) 2018-06-02 17:19 PDT, EWS Watchlist	no flags	Details
Patch (15.68 KB, patch) 2018-06-02 17:48 PDT, Daniel Bates	bfulgham: review+	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Daniel Bates 2018-06-02 15:31:17 PDT

Update Strong Password appearance.

Comment 1 Daniel Bates 2018-06-02 15:31:38 PDT

<rdar://problem/38183795>

Comment 2 Daniel Bates 2018-06-02 15:34:56 PDT

Created attachment 341853 [details]
For EWS

Comment 3 EWS Watchlist 2018-06-02 17:19:03 PDT Comment hidden (obsolete)

Comment on attachment 341853 [details]
For EWS

Attachment 341853 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7949901

New failing tests:
fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button.html
fast/forms/auto-fill-button/input-strong-password-auto-fill-button.html

Comment 4 EWS Watchlist 2018-06-02 17:19:05 PDT Comment hidden (obsolete)

Created attachment 341856 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

Comment 5 Daniel Bates 2018-06-02 17:48:28 PDT

Created attachment 341857 [details]
Patch

Comment 6 Daniel Bates 2018-06-02 17:50:46 PDT

Comment on attachment 341857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341857&action=review

> Source/WebCore/ChangeLog:15
> +        only apply inner text element styles when the field is not disabled or read-only and has

*only apply strong password-specific inner text element styles

(will fix before landing)

Comment 7 Brent Fulgham 2018-06-03 11:03:40 PDT

Comment on attachment 341857 [details]
Patch

r=me

Comment 8 Daniel Bates 2018-06-04 14:29:48 PDT

Committed r232480: <https://trac.webkit.org/changeset/232480>