Bug 186237 - FunctionRareData::m_objectAllocationProfileWatchpoint is racy
Summary: FunctionRareData::m_objectAllocationProfileWatchpoint is racy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks: 164904
  Show dependency treegraph
 
Reported: 2018-06-02 10:31 PDT by Filip Pizlo
Modified: 2018-06-07 14:02 PDT (History)
6 users (show)

See Also:


Attachments
the patch (3.53 KB, patch)
2018-06-02 10:34 PDT, Filip Pizlo
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2018-06-02 10:31:09 PDT
We initialize it blind and let it go into auto-watch mode once the DFG adds a watchpoint, but that means that we never notice that it fired if it fires between when the DFG decides to watch it and when it actually adds the watchpoint.
Comment 1 Filip Pizlo 2018-06-02 10:34:05 PDT
Created attachment 341847 [details]
the patch
Comment 2 Filip Pizlo 2018-06-07 14:01:34 PDT
Landed in https://trac.webkit.org/changeset/232598/webkit
Comment 3 Radar WebKit Bug Importer 2018-06-07 14:02:24 PDT
<rdar://problem/40909445>