Bug 186233 - [ESNext][BigInt] Implement support for "<<" and ">>"
Summary: [ESNext][BigInt] Implement support for "<<" and ">>"
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Lima
URL:
Keywords:
: 186232 (view as bug list)
Depends on: 190836
Blocks: 179001
  Show dependency treegraph
 
Reported: 2018-06-02 06:52 PDT by Caio Lima
Modified: 2018-11-14 09:21 PST (History)
5 users (show)

See Also:


Attachments
WIP - Patch (40.63 KB, patch)
2018-10-23 19:36 PDT, Caio Lima
no flags Details | Formatted Diff | Diff
WIP - Patch (40.75 KB, patch)
2018-11-07 07:28 PST, Caio Lima
no flags Details | Formatted Diff | Diff
WIP - Patch (40.79 KB, patch)
2018-11-14 09:20 PST, Caio Lima
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Lima 2018-06-02 06:52:38 PDT
...
Comment 1 Caio Lima 2018-10-23 19:36:18 PDT
Created attachment 353017 [details]
WIP - Patch
Comment 2 Build Bot 2018-10-23 19:39:31 PDT
Attachment 353017 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/JSBigInt.cpp:1244:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/runtime/JSBigInt.cpp:1319:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Caio Lima 2018-10-24 05:20:08 PDT
*** Bug 186232 has been marked as a duplicate of this bug. ***
Comment 4 Caio Lima 2018-11-07 07:28:48 PST
Created attachment 354092 [details]
WIP - Patch
Comment 5 Caio Lima 2018-11-07 07:29:20 PST
Comment on attachment 354092 [details]
WIP - Patch

Rebased with master
Comment 6 Caio Lima 2018-11-14 09:20:27 PST
Created attachment 354818 [details]
WIP - Patch