Bug 186233 - [ESNext][BigInt] Implement support for "<<" and ">>"
Summary: [ESNext][BigInt] Implement support for "<<" and ">>"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Lima
URL:
Keywords: InRadar
: 186232 (view as bug list)
Depends on: 190836
Blocks: 179001 192017
  Show dependency tree / graph
 
Reported: 2018-06-02 06:52 PDT by Caio Lima
Modified: 2018-12-02 09:09 PST (History)
8 users (show)

See Also:

Attachments
WIP - Patch (40.63 KB, patch)
2018-10-23 19:36 PDT, Caio Lima 		no flags Details | Formatted Diff | Diff
WIP - Patch (40.75 KB, patch)
2018-11-07 07:28 PST, Caio Lima 		no flags Details | Formatted Diff | Diff
WIP - Patch (40.79 KB, patch)
2018-11-14 09:20 PST, Caio Lima 		no flags Details | Formatted Diff | Diff
Patch (40.94 KB, patch)
2018-11-27 17:39 PST, Caio Lima 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Lima 2018-06-02 06:52:38 PDT 
...
Comment 1 Caio Lima 2018-10-23 19:36:18 PDT 
Created attachment 353017 [details]
WIP - Patch
Comment 2 EWS Watchlist 2018-10-23 19:39:31 PDT 
Attachment 353017 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/JSBigInt.cpp:1244:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/runtime/JSBigInt.cpp:1319:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Caio Lima 2018-10-24 05:20:08 PDT 
*** Bug 186232 has been marked as a duplicate of this bug. ***
Comment 4 Caio Lima 2018-11-07 07:28:48 PST 
Created attachment 354092 [details]
WIP - Patch
Comment 5 Caio Lima 2018-11-07 07:29:20 PST 
Comment on attachment 354092 [details]
WIP - Patch

Rebased with master
Comment 6 Caio Lima 2018-11-14 09:20:27 PST 
Created attachment 354818 [details]
WIP - Patch
Comment 7 Caio Lima 2018-11-27 17:39:19 PST 
Created attachment 355827 [details]
Patch
Comment 8 Yusuke Suzuki 2018-12-02 00:06:06 PST 
Comment on attachment 355827 [details]
Patch

r=me
Comment 9 Caio Lima 2018-12-02 08:42:20 PST 
Comment on attachment 355827 [details]
Patch

Thank you very much for the review!
Comment 10 WebKit Commit Bot 2018-12-02 09:08:53 PST 
Comment on attachment 355827 [details]
Patch

Clearing flags on attachment: 355827

Committed r238790: <https://trac.webkit.org/changeset/238790>
Comment 11 WebKit Commit Bot 2018-12-02 09:08:54 PST 
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2018-12-02 09:09:26 PST 
<rdar://problem/46403139>