RESOLVED FIXED186190
[GStreamer][MSE] MediaPlayerPrivateGStreamerMSE.h includes and forward declares PlaybackPipeline 
https://bugs.webkit.org/show_bug.cgi?id=186190
Summary [GStreamer][MSE] MediaPlayerPrivateGStreamerMSE.h includes and forward declar...
Xabier Rodríguez Calvar
Reported 2018-06-01 04:40:24 PDT
Ideally we could use just the forward declaration and remove the header but I wanted to inline some code using that and it looks like removing the forward declaration does not work cause the include seems to do nothing.
Attachments
Patch (2.84 KB, patch)
2018-06-04 07:28 PDT, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews206 for win-future (12.77 MB, application/zip)
2018-06-04 12:40 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Xabier Rodríguez Calvar
Comment 1 2018-06-04 07:28:39 PDT
Created attachment 341902 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2018-06-04 07:30:05 PDT
I just added this patch that I got from Enrique to fix this issue, I'll r+ myself if he agrees to get it landed.
Enrique Ocaña
Comment 3 2018-06-04 07:32:33 PDT
Yes, please, go ahead.
EWS Watchlist
Comment 4 2018-06-04 12:40:43 PDT
Comment on attachment 341902 [details] Patch Attachment 341902 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7979296 New failing tests: http/tests/security/contentSecurityPolicy/video-with-https-url-allowed-by-csp-media-src-star.html
EWS Watchlist
Comment 5 2018-06-04 12:40:54 PDT
Created attachment 341908 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
WebKit Commit Bot
Comment 6 2018-06-04 23:45:04 PDT
Comment on attachment 341902 [details] Patch Clearing flags on attachment: 341902 Committed r232505: <https://trac.webkit.org/changeset/232505>
WebKit Commit Bot
Comment 7 2018-06-04 23:45:06 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-06-04 23:47:08 PDT
<rdar://problem/40796784>
Note You need to log in before you can comment on or make changes to this bug.