Bug 18619 – Support continue, break, and return in try .. finally blocks

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Oliver Hunt]

Task tracking bug

[Oliver Hunt]

Created attachment 20688 [details]
Rewrite finalisers with the wonder and joy of jsr/sret

[Maciej Stachowiak]

Comment on attachment 20688 [details]
Rewrite finalisers with the wonder and joy of jsr/sret

The code seems ok on the substance, so I'll say r=me.

But here are some style suggestions:

1) The return address register is variously named it's returnRegister, returnAddrRegister, returnAddress, and in some confusing cases, returnAddressnReg. I think it should be retAddrDst (or returnAddrDst) for jsr, and retAddrSrc (or returnAddrSrc) for sret, just to make clear these instructions respectively read and write the return address.

2) Is it really right to call a finally block a "finaliser"? In the context of dynamic languages, a "finaliser" is typically a routine that runs when a garbage-collected object is destroyed.

3) In emitComplexJumpScopes, I would advise you to consider breaking some of the commented blocks into well-named helper functions.

[Oliver Hunt]

Committed r32269