Bug 186170 - run-jsc should pass the option to use dollar vm by default
Summary: run-jsc should pass the option to use dollar vm by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-31 17:24 PDT by Keith Miller
Modified: 2018-06-05 10:23 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.34 KB, patch)
2018-05-31 17:24 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2018-05-31 17:24:27 PDT 
run-jsc should pass the option to use dollar vm by default
Comment 1 Keith Miller 2018-05-31 17:24:51 PDT 
Created attachment 341715 [details]
Patch
Comment 2 Yusuke Suzuki 2018-06-02 13:59:50 PDT 
Comment on attachment 341715 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2018-06-02 17:49:18 PDT 
Comment on attachment 341715 [details]
Patch

Clearing flags on attachment: 341715

Committed r232448: <https://trac.webkit.org/changeset/232448>
Comment 4 WebKit Commit Bot 2018-06-02 17:49:20 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-06-02 17:50:17 PDT 
<rdar://problem/40751460>
Comment 6 Saam Barati 2018-06-05 10:19:44 PDT 
Why?
Comment 7 Keith Miller 2018-06-05 10:23:39 PDT 
(In reply to Saam Barati from comment #6)
> Why?

So when I want to run tests that use $vm I don't have to pass the option every time and I don't have to export JSC_useDollarVM=1.