Bug 186167 - [Cocoa] Web Automation: use the session delegate to perform window maximize
Summary: [Cocoa] Web Automation: use the session delegate to perform window maximize
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: BJ Burg
Keywords: InRadar
Depends on:
Reported: 2018-05-31 16:41 PDT by BJ Burg
Modified: 2018-06-01 09:08 PDT (History)
6 users (show)

See Also:

Patch (10.28 KB, patch)
2018-05-31 16:48 PDT, BJ Burg
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2018-05-31 16:41:24 PDT
Trying to do this from web APIs doesn't work well because of space needed for Dock. This is easier to do correctly on the browser side. And, some WebKit embedders may not have a notion of maximize, so doing it unconditionally doesn't make sense.
Comment 1 BJ Burg 2018-05-31 16:41:47 PDT
Comment 2 BJ Burg 2018-05-31 16:48:01 PDT
Created attachment 341705 [details]
Comment 3 EWS Watchlist 2018-05-31 16:51:26 PDT
Attachment 341705 [details] did not pass style-queue:

ERROR: Source/WebKit/UIProcess/Cocoa/AutomationSessionClient.mm:152:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 4 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 BJ Burg 2018-06-01 09:08:36 PDT
Committed r232396: <https://trac.webkit.org/changeset/232396>