Bug 186162 - DFGArrayModes needs to know more about CoW arrays
Summary: DFGArrayModes needs to know more about CoW arrays
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-31 14:33 PDT by Keith Miller
Modified: 2018-06-08 11:16 PDT (History)
8 users (show)

See Also:

Attachments
Patch (18.41 KB, patch)
2018-05-31 14:58 PDT, Keith Miller 		fpizlo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2018-05-31 14:33:40 PDT 
DFGArrayModes needs to know more about CoW arrays
Comment 1 Keith Miller 2018-05-31 14:58:53 PDT 
Created attachment 341694 [details]
Patch
Comment 2 Keith Miller 2018-05-31 14:59:27 PDT 
This fixes the base64 regression from the first CoW patch.
Comment 3 Keith Miller 2018-05-31 16:50:22 PDT 
Committed r232376: <https://trac.webkit.org/changeset/232376>
Comment 4 Radar WebKit Bug Importer 2018-05-31 16:53:21 PDT 
<rdar://problem/40704880>
Comment 5 Dawei Fenton (:realdawei) 2018-06-08 09:47:12 PDT 
After https://trac.webkit.org/changeset/232376 the following test has been failing quite frequently on macOS Wk2 Debug: 

Test Name:
inspector/console/webcore-logging.html

Flakiness Dashboard:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fconsole%2Fwebcore-logging.html

Sample stdio:
https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/builds/3602/steps/layout-test/logs/stdio

Sample Diff:
--- /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/inspector/console/webcore-logging-expected.txt
+++ /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/inspector/console/webcore-logging-actual.txt
@@ -33,6 +33,7 @@
 -- Running test case: Console.Logging.LogAsJSONWithoutRepeat
 PASS: Media logging disabled.
 PASS: Verbose media logging has been enabled.
+ERROR: TypeError: undefined is not an object (evaluating 'listener.call')
 PASS: Message logged as JSON.
 PASS: ConsoleMessage repeatCount is 1.
 PASS: Message logged as JSON.
Comment 6 Dawei Fenton (:realdawei) 2018-06-08 11:16:25 PDT 
I've been able to reproduce the failure on a local build of r232376 using the following command:

run-webkit-tests inspector/console/webcore-logging.html --debug --iter 50 -f -g --no-retry

The test passes reliably on the previous build (r232375)