DFGArrayModes needs to know more about CoW arrays
Created attachment 341694 [details] Patch
This fixes the base64 regression from the first CoW patch.
Committed r232376: <https://trac.webkit.org/changeset/232376>
<rdar://problem/40704880>
After https://trac.webkit.org/changeset/232376 the following test has been failing quite frequently on macOS Wk2 Debug: Test Name: inspector/console/webcore-logging.html Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fconsole%2Fwebcore-logging.html Sample stdio: https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/builds/3602/steps/layout-test/logs/stdio Sample Diff: --- /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/inspector/console/webcore-logging-expected.txt +++ /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/inspector/console/webcore-logging-actual.txt @@ -33,6 +33,7 @@ -- Running test case: Console.Logging.LogAsJSONWithoutRepeat PASS: Media logging disabled. PASS: Verbose media logging has been enabled. +ERROR: TypeError: undefined is not an object (evaluating 'listener.call') PASS: Message logged as JSON. PASS: ConsoleMessage repeatCount is 1. PASS: Message logged as JSON.
I've been able to reproduce the failure on a local build of r232376 using the following command: run-webkit-tests inspector/console/webcore-logging.html --debug --iter 50 -f -g --no-retry The test passes reliably on the previous build (r232375)