WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
186156
Update Fetch code to provide more useful exception messages
https://bugs.webkit.org/show_bug.cgi?id=186156
Summary
Update Fetch code to provide more useful exception messages
Chris Dumez
Reported
2018-05-31 12:26:55 PDT
Update Fetch code to provide more useful exception messages.
Attachments
Patch
(39.16 KB, patch)
2018-06-04 13:47 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(39.38 KB, patch)
2018-06-04 14:39 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(39.68 KB, patch)
2018-06-04 15:26 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(39.66 KB, patch)
2018-06-04 15:50 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2018-06-04 13:47:06 PDT
Created
attachment 341915
[details]
Patch
Chris Dumez
Comment 2
2018-06-04 14:39:08 PDT
Created
attachment 341920
[details]
Patch
youenn fablet
Comment 3
2018-06-04 14:52:03 PDT
Comment on
attachment 341920
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=341920&action=review
> Source/WebCore/Modules/fetch/FetchHeaders.cpp:41 > + return Exception { TypeError, makeString("Invalid header value: '", value, "'") };
Might be nice to give the header name as well?
> Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp:49 > + client->didFail(ResourceError { errorDomainWebKitInternal, 0, URL(), ASCIILiteral("Response is null") });
We should try to get more interesting error messages here, based on the rejected promise value for instance. I can add this as a follow-up.
> Source/WebKit/StorageProcess/ServiceWorker/WebSWServerConnection.cpp:259 > +void WebSWServerConnection::didFailFetch(FetchIdentifier fetchIdentifier, ResourceError&& error)
Can probably be a const ResourceError& given it is only used by Messages::ServiceWorkerClientFetch::DidFail
Chris Dumez
Comment 4
2018-06-04 15:26:27 PDT
Created
attachment 341923
[details]
Patch
WebKit Commit Bot
Comment 5
2018-06-04 15:28:33 PDT
Comment on
attachment 341923
[details]
Patch Rejecting
attachment 341923
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 341923, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!. Full output:
http://webkit-queues.webkit.org/results/7983650
Chris Dumez
Comment 6
2018-06-04 15:50:53 PDT
Created
attachment 341928
[details]
Patch
WebKit Commit Bot
Comment 7
2018-06-04 16:17:58 PDT
Comment on
attachment 341928
[details]
Patch Clearing flags on attachment: 341928 Committed
r232484
: <
https://trac.webkit.org/changeset/232484
>
WebKit Commit Bot
Comment 8
2018-06-04 16:18:00 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9
2018-06-04 16:18:16 PDT
<
rdar://problem/40785465
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug