Bug 186154 - Support Images Module Level 4's double-position gradient color stop syntax
Summary: Support Images Module Level 4's double-position gradient color stop syntax
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Enhancement
Assignee: Megan Gardner
URL:
Keywords: InRadar
: 189640 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-05-31 12:00 PDT by Florin Malita
Modified: 2018-09-18 14:38 PDT (History)
5 users (show)

See Also:


Attachments
Patch for landing (19.52 KB, patch)
2018-09-18 14:00 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Florin Malita 2018-05-31 12:00:46 PDT
CSS Images Module Level 4 extends the gradient color-stop syntax to support specifying two positions [1].  This is equivalent to repeating the color for each position, and comes in handy when defining solid color gradient spans -- e.g.

  red 0%, green 50%, green 100%   =>   red 0%, green 50% 100%

CSSWG has approved double-position color stop syntax for shipping ([2],[3]), and we are considering shipping in Blink [4].  Mozilla is also looking at implementing [5].

I'm opening this bug to get some signals from the WebKit community regarding this feature.

Thanks!


[1] https://drafts.csswg.org/css-images-4/#color-stop-syntax
[2] https://github.com/w3c/csswg-drafts/issues/2439
[3] https://www.w3.org/2018/03/28-css-minutes.html#item07
[4] https://groups.google.com/a/chromium.org/forum/#!topic/Blink-dev/8B9FbeTBIK0
[5] https://bugzilla.mozilla.org/show_bug.cgi?id=1352643
Comment 1 Florin Malita 2018-05-31 12:15:15 PDT
WPT coverage: https://wpt.fyi/results/css/css-images/gradient/color-stops-parsing.html
Comment 2 Megan Gardner 2018-09-18 13:58:08 PDT
*** Bug 189640 has been marked as a duplicate of this bug. ***
Comment 3 Megan Gardner 2018-09-18 13:58:56 PDT
<rdar://problem/44158152>
Comment 4 Megan Gardner 2018-09-18 14:00:51 PDT
Created attachment 350050 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-09-18 14:38:27 PDT
Comment on attachment 350050 [details]
Patch for landing

Clearing flags on attachment: 350050

Committed r236155: <https://trac.webkit.org/changeset/236155>
Comment 6 WebKit Commit Bot 2018-09-18 14:38:28 PDT
All reviewed patches have been landed.  Closing bug.