Bug 186150 - Don't attempt to extend sandbox when running tests with mock media devices
Summary: Don't attempt to extend sandbox when running tests with mock media devices
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on: 185526
Blocks:
  Show dependency tree / graph
 
Reported: 2018-05-31 10:33 PDT by Brent Fulgham
Modified: 2018-05-31 12:13 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.18 KB, patch)
2018-05-31 10:41 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch for landing (2.22 KB, patch)
2018-05-31 10:49 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2018-05-31 10:33:22 PDT 
Various WebKit media tests can fail when TCC prompts are displayed when WebKitTestRunner attempts to create sandbox extensions for media capture devices.

When running our test infrastructure, we use Mock devices, which do not need these extensions, and should not be creating any prompts.

This patch revises the media capture device logic to avoid extending the sandbox for mock test devices.
Comment 1 Brent Fulgham 2018-05-31 10:41:06 PDT 
Created attachment 341672 [details]
Patch
Comment 2 Brent Fulgham 2018-05-31 10:49:06 PDT 
<rdar://problem/40690875>
Comment 3 Brent Fulgham 2018-05-31 10:49:45 PDT 
Created attachment 341673 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2018-05-31 12:13:41 PDT 
Comment on attachment 341673 [details]
Patch for landing

Clearing flags on attachment: 341673

Committed r232360: <https://trac.webkit.org/changeset/232360>
Comment 5 WebKit Commit Bot 2018-05-31 12:13:42 PDT 
All reviewed patches have been landed.  Closing bug.