WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
186139
[GTK] imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property.html failing since
r232255
"[Web Animations] Handle relative length units"
https://bugs.webkit.org/show_bug.cgi?id=186139
Summary
[GTK] imported/w3c/web-platform-tests/web-animations/animation-model/animatio...
Miguel Gomez
Reported
2018-05-31 02:58:36 PDT
imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property.html [ Failure ] diff is here
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r232336%20(6827)/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-pretty-diff.html
Attachments
Patch
(187.10 KB, patch)
2020-04-05 22:59 PDT
,
Manuel Rego Casasnovas
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alicia Boya García
Comment 1
2019-08-28 18:32:47 PDT
Now timing out...
Manuel Rego Casasnovas
Comment 2
2020-04-05 22:59:33 PDT
Created
attachment 395547
[details]
Patch
Manuel Rego Casasnovas
Comment 3
2020-04-05 23:02:35 PDT
This is basically a gardening patch, as these tests run just fine locally (no timeout). I've also updated the -expected.txt results according to what I get running them locally. Is there any easy way to verify that these tests run fine on the bots? Also to check that these results are the same on the bots? Should we just merge this and wait for the bots results? Sorry but I don't know what you usually do in these cases, adding a few people on CC that might be able to help me with this. Thanks. :-)
Carlos Alberto Lopez Perez
Comment 4
2020-04-06 09:31:38 PDT
Comment on
attachment 395547
[details]
Patch Looks fine! thanks
Manuel Rego Casasnovas
Comment 5
2020-04-06 12:51:46 PDT
***
Bug 184086
has been marked as a duplicate of this bug. ***
EWS
Comment 6
2020-04-06 13:37:16 PDT
Committed
r259592
: <
https://trac.webkit.org/changeset/259592
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 395547
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug