Bug 186139 - [GTK] imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property.html failing since r232255 "[Web Animations] Handle relative length units"
Summary: [GTK] imported/w3c/web-platform-tests/web-animations/animation-model/animatio...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords:
: 184086 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-05-31 02:58 PDT by Miguel Gomez
Modified: 2020-04-06 13:37 PDT (History)
8 users (show)

See Also:


Attachments
Patch (187.10 KB, patch)
2020-04-05 22:59 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gomez 2018-05-31 02:58:36 PDT
imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property.html [ Failure ]

diff is here
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r232336%20(6827)/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-pretty-diff.html
Comment 1 Alicia Boya García 2019-08-28 18:32:47 PDT
Now timing out...
Comment 2 Manuel Rego Casasnovas 2020-04-05 22:59:33 PDT
Created attachment 395547 [details]
Patch
Comment 3 Manuel Rego Casasnovas 2020-04-05 23:02:35 PDT
This is basically a gardening patch, as these tests run just fine locally (no timeout).
I've also updated the -expected.txt results according to what I get running them locally.

Is there any easy way to verify that these tests run fine on the bots? Also to check that these results are the same on the bots? Should we just merge this and wait for the bots results?

Sorry but I don't know what you usually do in these cases, adding a few people on CC that might be able to help me with this. Thanks. :-)
Comment 4 Carlos Alberto Lopez Perez 2020-04-06 09:31:38 PDT
Comment on attachment 395547 [details]
Patch

Looks fine! thanks
Comment 5 Manuel Rego Casasnovas 2020-04-06 12:51:46 PDT
*** Bug 184086 has been marked as a duplicate of this bug. ***
Comment 6 EWS 2020-04-06 13:37:16 PDT
Committed r259592: <https://trac.webkit.org/changeset/259592>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395547 [details].