RESOLVED FIXED 186137
http/tests/inspector/network/har/har-page.html should actually sort dumped cookies by name 
https://bugs.webkit.org/show_bug.cgi?id=186137
Summary http/tests/inspector/network/har/har-page.html should actually sort dumped co...
Miguel Gomez
Reported 2018-05-31 02:49:06 PDT
http/tests/inspector/network/har/har-page.html [ Failure ] Diff can be found here https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r232336%20(6827)/http/tests/inspector/network/har/har-page-pretty-diff.html
Attachments
Patch (4.80 KB, patch)
2018-05-31 12:06 PDT, Daniel Bates 		joepeck: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews206 for win-future (12.74 MB, application/zip)
2018-06-01 05:58 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2018-05-31 07:02:46 PDT
We don't yet support Same-Site cookies, I added it to the cooking pot.
Daniel Bates
Comment 2 2018-05-31 08:04:00 PDT
We just need to add port-specific test results for this test.
Daniel Bates
Comment 3 2018-05-31 11:55:13 PDT
(In reply to Daniel Bates from comment #2) > We just need to add port-specific test results for this test. Actually, the comparator function in the test is incorrect for String data types. We need to implement using relational operators and the identity operator.
Daniel Bates
Comment 4 2018-05-31 12:06:28 PDT
Created attachment 341683 [details] Patch
Daniel Bates
Comment 5 2018-05-31 12:07:56 PDT
Relational operators work for Strings per <https://tc39.github.io/ecma262/#sec-abstract-relational-comparison>.
EWS Watchlist
Comment 6 2018-06-01 05:57:54 PDT
Comment on attachment 341683 [details] Patch Attachment 341683 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7923750 New failing tests: http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html http/tests/security/canvas-remote-read-remote-video-localhost.html
EWS Watchlist
Comment 7 2018-06-01 05:58:06 PDT
Created attachment 341753 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Daniel Bates
Comment 8 2018-06-01 12:27:51 PDT
(In reply to Build Bot from comment #6) > Comment on attachment 341683 [details] > Patch > > Attachment 341683 [details] did not pass win-ews (win): > Output: http://webkit-queues.webkit.org/results/7923750 > > New failing tests: > http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin. > html > http/tests/security/canvas-remote-read-remote-video-localhost.html This test failure is unrelated to the changes in this patch.
Joseph Pecoraro
Comment 9 2018-06-01 12:39:42 PDT
Comment on attachment 341683 [details] Patch r=me
Daniel Bates
Comment 10 2018-06-01 13:41:16 PDT
Committed r232413: <https://trac.webkit.org/changeset/232413>
Radar WebKit Bug Importer
Comment 11 2018-06-01 13:43:10 PDT
<rdar://problem/40732694>
Note You need to log in before you can comment on or make changes to this bug.