Bug 186137 - http/tests/inspector/network/har/har-page.html should actually sort dumped cookies by name
Summary: http/tests/inspector/network/har/har-page.html should actually sort dumped co...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on: 184897
Blocks:
  Show dependency treegraph
 
Reported: 2018-05-31 02:49 PDT by Miguel Gomez
Modified: 2018-06-01 13:43 PDT (History)
9 users (show)

See Also:


Attachments
Patch (4.80 KB, patch)
2018-05-31 12:06 PDT, Daniel Bates
joepeck: review+
ews: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (12.74 MB, application/zip)
2018-06-01 05:58 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gomez 2018-05-31 02:49:06 PDT
http/tests/inspector/network/har/har-page.html [ Failure ]

Diff can be found here
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r232336%20(6827)/http/tests/inspector/network/har/har-page-pretty-diff.html
Comment 1 Michael Catanzaro 2018-05-31 07:02:46 PDT
We don't yet support Same-Site cookies, I added it to the cooking pot.
Comment 2 Daniel Bates 2018-05-31 08:04:00 PDT
We just need to add port-specific test results for this test.
Comment 3 Daniel Bates 2018-05-31 11:55:13 PDT
(In reply to Daniel Bates from comment #2)
> We just need to add port-specific test results for this test.

Actually, the comparator function in the test is incorrect for String data types. We need to implement using relational operators and the identity operator.
Comment 4 Daniel Bates 2018-05-31 12:06:28 PDT
Created attachment 341683 [details]
Patch
Comment 5 Daniel Bates 2018-05-31 12:07:56 PDT
Relational operators work for Strings per <https://tc39.github.io/ecma262/#sec-abstract-relational-comparison>.
Comment 6 Build Bot 2018-06-01 05:57:54 PDT
Comment on attachment 341683 [details]
Patch

Attachment 341683 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7923750

New failing tests:
http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
http/tests/security/canvas-remote-read-remote-video-localhost.html
Comment 7 Build Bot 2018-06-01 05:58:06 PDT
Created attachment 341753 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 8 Daniel Bates 2018-06-01 12:27:51 PDT
(In reply to Build Bot from comment #6)
> Comment on attachment 341683 [details]
> Patch
> 
> Attachment 341683 [details] did not pass win-ews (win):
> Output: http://webkit-queues.webkit.org/results/7923750
> 
> New failing tests:
> http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.
> html
> http/tests/security/canvas-remote-read-remote-video-localhost.html

This test failure is unrelated to the changes in this patch.
Comment 9 Joseph Pecoraro 2018-06-01 12:39:42 PDT
Comment on attachment 341683 [details]
Patch

r=me
Comment 10 Daniel Bates 2018-06-01 13:41:16 PDT
Committed r232413: <https://trac.webkit.org/changeset/232413>
Comment 11 Radar WebKit Bug Importer 2018-06-01 13:43:10 PDT
<rdar://problem/40732694>