Bug 186133 - export-w3c-test-changes cannot apply patches when some w3c-import.log files are changed
Summary: export-w3c-test-changes cannot apply patches when some w3c-import.log files a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-31 02:21 PDT by Frédéric Wang (:fredw)
Modified: 2018-06-01 10:04 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.02 KB, patch)
2018-05-31 05:32 PDT, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2018-05-31 02:21:47 PDT 
I've tried to export a WPT test that I have previously imported from a local web-platform-test repo. The import script has modified some w3c-import.log files in WebKit and hence these changes are included into the patch used by the export-w3c-test-changes script. Since these w3c-import.log files don't exist in the web-platform-test repo, the patch fails to apply.

I realize this is not really a standard workflow, but maybe export-w3c-test-changes should exclude these w3c-import.log files when producing the patch to apply.
Comment 1 Frédéric Wang (:fredw) 2018-05-31 05:32:57 PDT 
Created attachment 341661 [details]
Patch
Comment 2 WebKit Commit Bot 2018-06-01 09:36:06 PDT 
Comment on attachment 341661 [details]
Patch

Clearing flags on attachment: 341661

Committed r232398: <https://trac.webkit.org/changeset/232398>
Comment 3 WebKit Commit Bot 2018-06-01 09:36:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-06-01 10:04:33 PDT 
<rdar://problem/40724859>