emitMove should only emit the move if it's actually needed
Created attachment 341637 [details] Patch
Comment on attachment 341637 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341637&action=review > Source/JavaScriptCore/ChangeLog:10 > + This patch relpaces emitMove with moveToDestinationIfNeeded. This > + will prevent us from emiting moves to the same location. The old > + emitMove, has been renamed to emitMov and made private. That's a lot of semantic weight for the letter "e" to carry. :P How about calling the private function "emitMoveWithoutDestinationCheck". Or you can call the public function "move" and the private function "emitMove". "emit*" in the BytecodeGenerator usually means the lowest level function that splats out an opcode.
Comment on attachment 341637 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341637&action=review >> Source/JavaScriptCore/ChangeLog:10 >> + emitMove, has been renamed to emitMov and made private. > > That's a lot of semantic weight for the letter "e" to carry. :P > > How about calling the private function "emitMoveWithoutDestinationCheck". > > Or you can call the public function "move" and the private function "emitMove". "emit*" in the BytecodeGenerator usually means the lowest level function that splats out an opcode. "e" is the important (common) letter in the English language! I'll do the latter.
Created attachment 341641 [details] Patch
Comment on attachment 341641 [details] Patch Attachment 341641 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7885426 New failing tests: imported/w3c/web-platform-tests/streams/piping/error-propagation-forward.html
Created attachment 341642 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Is that Mac test failure real?
(In reply to Geoffrey Garen from comment #7) > Is that Mac test failure real? Seems pretty unlikely, although I suppose it could be. IMO, it's probably due to a more fundamental line tracking bug if it is so we should just rebaseline the test and file another bug.
Created attachment 341711 [details] Patch
Comment on attachment 341711 [details] Patch Clearing flags on attachment: 341711 Committed r232399: <https://trac.webkit.org/changeset/232399>
All reviewed patches have been landed. Closing bug.
<rdar://problem/40727627>