Bug 186117 - [LFC] Layout code needs to know the type of the Element associated with a Layout::Box
Summary: [LFC] Layout code needs to know the type of the Element associated with a Lay...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-30 16:31 PDT by zalan
Modified: 2018-05-31 09:52 PDT (History)
6 users (show)

See Also:


Attachments
Patch (15.20 KB, patch)
2018-05-30 16:39 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (15.10 KB, patch)
2018-05-31 09:14 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-05-30 16:31:52 PDT
for example we need to know if the box is associated with the <body> and size it differently in quirks mode.
Comment 1 zalan 2018-05-30 16:39:03 PDT
Created attachment 341620 [details]
Patch
Comment 2 Antti Koivisto 2018-05-31 07:35:03 PDT
Comment on attachment 341620 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341620&action=review

> Source/WebCore/layout/layouttree/LayoutBox.h:120
> +    struct ElementAttributes {
> +        ElementAttributes(ElementType elementType)
> +            : elementType(elementType)
> +            {
> +            }
> +
> +        ElementType elementType;
> +    };

Indentation for
{
}
is wrong.

Is the constructor needed? Maybe this could just use bracket initialization?
Comment 3 zalan 2018-05-31 09:14:54 PDT
Created attachment 341666 [details]
Patch
Comment 4 WebKit Commit Bot 2018-05-31 09:43:58 PDT
Comment on attachment 341666 [details]
Patch

Clearing flags on attachment: 341666

Committed r232350: <https://trac.webkit.org/changeset/232350>
Comment 5 WebKit Commit Bot 2018-05-31 09:43:59 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-05-31 09:52:03 PDT
<rdar://problem/40688526>