Add setting to allow override screen size to be disabled.
<rdar://problem/40277044>
Created attachment 341603 [details] Patch
Comment on attachment 341603 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341603&action=review > Source/WebCore/page/DeprecatedGlobalSettings.cpp:75 > +bool DeprecatedGlobalSettings::gDisableScreenSizeOverride = true; Shouldn't this default to false? > Source/WebCore/page/Settings.yaml:154 > +disableScreenSizeOverride: > + initial: false I don't think you need this for global settings. > Source/WebKit/UIProcess/WebPageProxy.cpp:453 > + DeprecatedGlobalSettings::setDisableScreenSizeOverride(preferencesStore().getBoolValueForKey(WebPreferencesKey::disableScreenSizeOverrideKey())); Doesn't something need to send this setting to the web process?
(In reply to Andy Estes from comment #3) > Comment on attachment 341603 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=341603&action=review > > > Source/WebKit/UIProcess/WebPageProxy.cpp:453 > > + DeprecatedGlobalSettings::setDisableScreenSizeOverride(preferencesStore().getBoolValueForKey(WebPreferencesKey::disableScreenSizeOverrideKey())); > > Doesn't something need to send this setting to the web process? I guess not, because we always query screen size in the UI process (then pass it to the web process in WebPageCreationParameters)!
Created attachment 341609 [details] Patch
Created attachment 341616 [details] Patch
Comment on attachment 341616 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341616&action=review > Source/WebCore/page/Settings.yaml:153 > +disableScreenSizeOverride: I don't think we need this in Settings.yaml if we're putting this in DeprecatedGlobalSettings, since this will generate a derived getters and setters in Settings.
Comment on attachment 341616 [details] Patch Clearing flags on attachment: 341616 Committed r232372: <https://trac.webkit.org/changeset/232372>
All reviewed patches have been landed. Closing bug.
Is there any way to achieve this without adding to DeprecatedGlobalSettings? The goal is to reduce usage of that class and eventually remove it, hence the 'Deprecated' part.
There really isn't, given the places where override screen size is called from. This trajectory was cleared with Tim and Andy before it was embarked on.