Bug 186092 - Block more ports (427, 548, 6697)
Summary: Block more ports (427, 548, 6697)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-30 07:27 PDT by Anne van Kesteren
Modified: 2018-11-28 00:29 PST (History)
7 users (show)

See Also:


Attachments
Patch (22.31 KB, patch)
2018-11-23 11:27 PST, Rob Buis
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.61 MB, application/zip)
2018-11-24 01:45 PST, EWS Watchlist
no flags Details
Patch (22.31 KB, patch)
2018-11-25 11:47 PST, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (22.47 KB, patch)
2018-11-26 10:54 PST, Rob Buis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anne van Kesteren 2018-05-30 07:27:41 PDT
See https://github.com/whatwg/fetch/pull/738 for the change to the Fetch Standard.

Chrome already blocks 6697 and is planning on blocking the other two as well. So I suspect you can ship 6697 directly, but might want to consider coordinating the others.

https://github.com/web-platform-tests/wpt/pull/11249 updates the tests.
Comment 1 Radar WebKit Bug Importer 2018-05-30 20:10:57 PDT
<rdar://problem/40673291>
Comment 2 Rob Buis 2018-11-23 11:27:07 PST
Created attachment 355528 [details]
Patch
Comment 3 EWS Watchlist 2018-11-23 11:29:22 PST
Attachment 355528 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/URL.cpp:922:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 EWS Watchlist 2018-11-24 01:45:00 PST
Comment on attachment 355528 [details]
Patch

Attachment 355528 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10126662

New failing tests:
media/no-fullscreen-when-hidden.html
Comment 5 EWS Watchlist 2018-11-24 01:45:01 PST
Created attachment 355559 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 6 Rob Buis 2018-11-25 11:47:31 PST
Created attachment 355600 [details]
Patch
Comment 7 EWS Watchlist 2018-11-25 11:49:52 PST
Attachment 355600 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/URL.cpp:922:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Rob Buis 2018-11-25 13:34:01 PST
Comment on attachment 355600 [details]
Patch

The style error is a bit silly and I think we can ignore it.
Comment 9 Frédéric Wang (:fredw) 2018-11-26 01:23:36 PST
Comment on attachment 355600 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355600&action=review

> Source/WebCore/ChangeLog:8
> +        Block port 427.

Maybe explain a bit more. In particular that 548 and 6697 are already blocked, we just extend WPT coverage to verify these ports too.

> LayoutTests/imported/w3c/ChangeLog:8
> +        Update equest-bad-port.html to latest version.

request-bad-port.html
Comment 10 Rob Buis 2018-11-26 10:54:47 PST
Created attachment 355655 [details]
Patch
Comment 11 EWS Watchlist 2018-11-26 10:56:01 PST
Attachment 355655 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/URL.cpp:922:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 Rob Buis 2018-11-28 00:29:06 PST
Landed as r238604.