Bug 186092 – Block more ports (427, 548, 6697)

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Anne van Kesteren]

See https://github.com/whatwg/fetch/pull/738 for the change to the Fetch Standard.

Chrome already blocks 6697 and is planning on blocking the other two as well. So I suspect you can ship 6697 directly, but might want to consider coordinating the others.

https://github.com/web-platform-tests/wpt/pull/11249 updates the tests.

[Radar WebKit Bug Importer]

<rdar://problem/40673291>

[Rob Buis]

Created attachment 355528 [details]
Patch

[EWS Watchlist]

Attachment 355528 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/URL.cpp:922:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 355528 [details]
Patch

Attachment 355528 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10126662

New failing tests:
media/no-fullscreen-when-hidden.html

[EWS Watchlist]

Created attachment 355559 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Rob Buis]

Created attachment 355600 [details]
Patch

[EWS Watchlist]

Attachment 355600 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/URL.cpp:922:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Rob Buis]

Comment on attachment 355600 [details]
Patch

The style error is a bit silly and I think we can ignore it.

[Frédéric Wang (:fredw)]

Comment on attachment 355600 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355600&action=review

> Source/WebCore/ChangeLog:8
> +        Block port 427.

Maybe explain a bit more. In particular that 548 and 6697 are already blocked, we just extend WPT coverage to verify these ports too.

> LayoutTests/imported/w3c/ChangeLog:8
> +        Update equest-bad-port.html to latest version.

request-bad-port.html

[Rob Buis]

Created attachment 355655 [details]
Patch

[EWS Watchlist]

Attachment 355655 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/URL.cpp:922:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Rob Buis]

Landed as r238604.