Bug 186088 – Make WKWebView firstResponder after entering or exiting fullscreen.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Jeremy Jones]

Make WKWebView firstResponder after entering or exiting fullscreen.

[Jeremy Jones]

*** Bug 186087 has been marked as a duplicate of this bug. ***

[Jeremy Jones]

rdar://problem/40387859

[Jeremy Jones]

Created attachment 341561 [details]
Patch

[Jon Lee]

Comment on attachment 341561 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341561&action=review

> Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:538
> +            [webView becomeFirstResponder];

This block inconsistently references the web view with a local variable and a member variable. Which one should it be?

[Jeremy Jones]

Created attachment 341806 [details]
Patch

[Jeremy Jones]

(In reply to Jon Lee from comment #4)
> Comment on attachment 341561 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=341561&action=review
> 
> > Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:538
> > +            [webView becomeFirstResponder];
> 
> This block inconsistently references the web view with a local variable and
> a member variable. Which one should it be?

Fixed.

[WebKit Commit Bot]

Comment on attachment 341806 [details]
Patch

Clearing flags on attachment: 341806

Committed r232438: <https://trac.webkit.org/changeset/232438>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.