Bug 186083 - [LFC] Miscellaneous fixes to get closer to geometry correctness
Summary: [LFC] Miscellaneous fixes to get closer to geometry correctness
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-29 22:00 PDT by zalan
Modified: 2018-05-30 08:27 PDT (History)
6 users (show)

See Also:

Attachments
Patch (19.03 KB, patch)
2018-05-30 07:32 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (19.05 KB, patch)
2018-05-30 07:47 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (19.08 KB, patch)
2018-05-30 07:58 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-05-29 22:00:03 PDT 
when laying out <div></div>
Comment 1 zalan 2018-05-30 07:32:50 PDT 
Created attachment 341569 [details]
Patch
Comment 2 Antti Koivisto 2018-05-30 07:41:45 PDT 
Comment on attachment 341569 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341569&action=review

> Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp:120
> +    auto width = [&]() {

computeWidth() maybe? width() sounds like an accessor.
Comment 3 zalan 2018-05-30 07:47:33 PDT 
Created attachment 341573 [details]
Patch
Comment 4 zalan 2018-05-30 07:58:27 PDT 
Created attachment 341574 [details]
Patch
Comment 5 WebKit Commit Bot 2018-05-30 08:26:56 PDT 
Comment on attachment 341574 [details]
Patch

Clearing flags on attachment: 341574

Committed r232291: <https://trac.webkit.org/changeset/232291>
Comment 6 WebKit Commit Bot 2018-05-30 08:26:58 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-05-30 08:27:17 PDT 
<rdar://problem/40650779>