Bug 186079 - [Win][MiniBrowser] Move MainWindow related code from Common.cpp to MainWindow.cpp
Summary: [Win][MiniBrowser] Move MainWindow related code from Common.cpp to MainWindow...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks: 184770
  Show dependency tree / graph
 
Reported: 2018-05-29 20:19 PDT by Fujii Hironori
Modified: 2018-05-30 20:36 PDT (History)
6 users (show)

See Also:

Attachments
Patch (25.20 KB, patch)
2018-05-29 20:38 PDT, Fujii Hironori 		achristensen: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2018-05-29 20:19:27 PDT 
[Win][MiniBrowser] Move MainWindow related code from Common.cpp to MainWindow.cpp

This is a sub task of Bug 184770.
Comment 1 Fujii Hironori 2018-05-29 20:38:13 PDT 
Created attachment 341553 [details]
Patch
Comment 2 EWS Watchlist 2018-05-29 20:40:06 PDT 
Attachment 341553 [details] did not pass style-queue:


ERROR: Tools/MiniBrowser/win/Common.cpp:29:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Tools/MiniBrowser/win/Common.cpp:30:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Tools/MiniBrowser/win/WinMain.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Tools/MiniBrowser/win/Common.h:28:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 4 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Fujii Hironori 2018-05-30 14:36:29 PDT 
Could you review?
Comment 4 Alex Christensen 2018-05-30 14:47:33 PDT 
Comment on attachment 341553 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341553&action=review

> Tools/MiniBrowser/win/WinMain.cpp:-33
> -#include "Common.cpp"

!
Comment 5 Fujii Hironori 2018-05-30 20:31:44 PDT 
Committed r232333: <https://trac.webkit.org/changeset/232333>
Comment 6 Radar WebKit Bug Importer 2018-05-30 20:36:58 PDT 
<rdar://problem/40673691>