Bug 186077 - Update default Resource Timing buffer size from 150 to 250
Summary: Update default Resource Timing buffer size from 150 to 250
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-29 18:19 PDT by Nic Jansma
Modified: 2024-03-12 16:25 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nic Jansma 2018-05-29 18:19:12 PDT
Per https://github.com/w3c/resource-timing/pull/155, the ResourceTiming default buffer size should be increased from 150 to 250.
Comment 1 Ahmad Saleem 2024-03-10 19:41:21 PDT
We have this function - setResourceTimingBufferSize

https://searchfox.org/wubkat/rev/c67bb750f2c1083399f0dbe7d08b416cd45eee34/Source/WebCore/page/Performance.cpp#247

Although looking into WPT: https://wpt.fyi/results/resource-timing?label=master&label=experimental&aligned&q=buffer

Safari seems to pass all tests, do we need to do anything here?

@Ryosuke - any input or whom might be right person to comment on this?
Comment 2 Ryosuke Niwa 2024-03-11 20:40:29 PDT
We still have 150 hard-coded in Performance.h. We need to update it to 250 per spec: https://w3c.github.io/resource-timing/#sec-extensions-performance-interface
Comment 3 Ahmad Saleem 2024-03-11 20:45:54 PDT
(In reply to Ryosuke Niwa from comment #2)
> We still have 150 hard-coded in Performance.h. We need to update it to 250
> per spec:
> https://w3c.github.io/resource-timing/#sec-extensions-performance-interface

Is it just to update this?

https://searchfox.org/wubkat/rev/711120e7edec012527620d07bf63d85713a180fd/Source/WebCore/page/Performance.h#146

unsigned m_resourceTimingBufferSize { 150 };

Can do PR to update it to 250 with reference to web-spec, do I need to adjust any tests?
Comment 4 Ahmad Saleem 2024-03-11 20:52:03 PDT
Draft PR - https://github.com/WebKit/WebKit/pull/25757

Let's see what happens.
Comment 5 Ryosuke Niwa 2024-03-11 21:00:12 PDT
Pull request: https://github.com/WebKit/WebKit/pull/25758
Comment 6 EWS 2024-03-12 16:24:19 PDT
Committed 276007@main (94cf8a4a86fc): <https://commits.webkit.org/276007@main>

Reviewed commits have been landed. Closing PR #25758 and removing active labels.
Comment 7 Radar WebKit Bug Importer 2024-03-12 16:25:14 PDT
<rdar://problem/124487568>