Bug 186077 – Update default Resource Timing buffer size from 150 to 250

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Nic Jansma]

Per https://github.com/w3c/resource-timing/pull/155, the ResourceTiming default buffer size should be increased from 150 to 250.

[Ahmad Saleem]

We have this function - setResourceTimingBufferSize

https://searchfox.org/wubkat/rev/c67bb750f2c1083399f0dbe7d08b416cd45eee34/Source/WebCore/page/Performance.cpp#247

Although looking into WPT: https://wpt.fyi/results/resource-timing?label=master&label=experimental&aligned&q=buffer

Safari seems to pass all tests, do we need to do anything here?

@Ryosuke - any input or whom might be right person to comment on this?

[Ryosuke Niwa]

We still have 150 hard-coded in Performance.h. We need to update it to 250 per spec: https://w3c.github.io/resource-timing/#sec-extensions-performance-interface

[Ahmad Saleem]

(In reply to Ryosuke Niwa from comment #2)
> We still have 150 hard-coded in Performance.h. We need to update it to 250
> per spec:
> https://w3c.github.io/resource-timing/#sec-extensions-performance-interface

Is it just to update this?

https://searchfox.org/wubkat/rev/711120e7edec012527620d07bf63d85713a180fd/Source/WebCore/page/Performance.h#146

unsigned m_resourceTimingBufferSize { 150 };

Can do PR to update it to 250 with reference to web-spec, do I need to adjust any tests?

[Ahmad Saleem]

Draft PR - https://github.com/WebKit/WebKit/pull/25757

Let's see what happens.

[Ryosuke Niwa]

Pull request: https://github.com/WebKit/WebKit/pull/25758

[EWS]

Committed 276007@main (94cf8a4a86fc): <https://commits.webkit.org/276007@main>

Reviewed commits have been landed. Closing PR #25758 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/124487568>