Bug 186064 - Add a version of JSVirtualMachine shrinkFootprint that runs when the VM goes idle
Summary: Add a version of JSVirtualMachine shrinkFootprint that runs when the VM goes ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-29 15:11 PDT by Saam Barati
Modified: 2018-05-29 21:37 PDT (History)
13 users (show)

See Also:

Attachments
patch (3.59 KB, patch)
2018-05-29 15:32 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (5.74 KB, patch)
2018-05-29 16:38 PDT, Saam Barati 		mark.lam: review+
Details | Formatted Diff | Diff
patch for landing (5.76 KB, patch)
2018-05-29 19:24 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-05-29 15:11:42 PDT 
This will give us a better opportunity at freeing memory in the GC since we can't delete all code until the VM goes idle.
Comment 1 Saam Barati 2018-05-29 15:32:31 PDT 
Created attachment 341529 [details]
patch
Comment 2 Saam Barati 2018-05-29 16:38:05 PDT 
Created attachment 341536 [details]
patch
Comment 3 Mark Lam 2018-05-29 16:41:14 PDT 
Comment on attachment 341536 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341536&action=review

r=me

> Source/JavaScriptCore/runtime/VM.cpp:785
> +        heap.collectNow(Synchronousness::Sync);

This didn't pick up your Full GC fix.
Comment 4 Saam Barati 2018-05-29 16:44:27 PDT 
Comment on attachment 341536 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341536&action=review

>> Source/JavaScriptCore/runtime/VM.cpp:785
>> +        heap.collectNow(Synchronousness::Sync);
> 
> This didn't pick up your Full GC fix.

Good catch. Will fix.
Comment 5 Saam Barati 2018-05-29 19:24:38 PDT 
Created attachment 341548 [details]
patch for landing
Comment 6 WebKit Commit Bot 2018-05-29 21:36:12 PDT 
Comment on attachment 341548 [details]
patch for landing

Clearing flags on attachment: 341548

Committed r232286: <https://trac.webkit.org/changeset/232286>
Comment 7 WebKit Commit Bot 2018-05-29 21:36:14 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-05-29 21:37:25 PDT 
<rdar://problem/40639828>