Bug 186060 – Store 0-lifetime stylesheets / scripts into the disk cache for faster history navigations

• Status: RESOLVED
• Resolution: INVALID
• Component: WebKit2

[Chris Dumez]

Store 0-lifetime stylesheets / scripts into the disk cache for faster history navigations. In particular, on apple.com, several of the scripts / stylesheets currently do not get stored because our current heuristic thinks they are unlikely to be reused.

For e.g.:
Summary
URL: https://www.apple.com/ac/globalfooter/3/en_US/styles/ac-globalfooter.built.css
Status: 200 OK

Request
No request, served from the disk cache.

Response
Date: Tue, 29 May 2018 20:41:41 GMT
Connection: keep-alive
Content-Encoding: gzip
Access-Control-Allow-Origin: https://www.apple.com
Expires: Tue, 29 May 2018 20:41:41 GMT
Cache-Control: max-age=0
Content-Length: 5212
Vary: Accept-Encoding
Content-Type: text/css
Server: Apache
X-Check-Cacheable: YES
X-Serial: 6858

[Radar WebKit Bug Importer]

<rdar://problem/40627270>

[Chris Dumez]

Created attachment 341515 [details]
Patch

[Geoffrey Garen]

Comment on attachment 341515 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341515&action=review

r=me

> Source/WebKit/ChangeLog:9
> +        Tweak our storeUnconditionallyForHistoryNavigation logic to match resources' whose priority

resources

[Chris Dumez]

Created attachment 341519 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 341519 [details]
Patch

Clearing flags on attachment: 341519

Committed r232275: <https://trac.webkit.org/changeset/232275>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

Reverted r232275 for reason:

May have caused a ~1% PLT regression on iOS

Committed r232447: <https://trac.webkit.org/changeset/232447>

[Chris Dumez]

Apparently too costly. I don't have a better idea at the moment.

[Antti Koivisto]

This seems like something the site should fix rather than something we should optimise for.