Bug 186058 – Disable keyboard in fullscreen ios.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Jeremy Jones]

Disable keyboard in fullscreen ios.

[Jeremy Jones]

rdar://problem/36187333

[Jeremy Jones]

Created attachment 341509 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 341509 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341509&action=review

> Source/WebKit/ChangeLog:8
> +        Disallow keyboard in ios fullscreen. This will still allow select keys useful for playback.

Can we add a layout test for this?

[Jon Lee]

Comment on attachment 341509 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341509&action=review

> Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp:104
>  void WebFullScreenManagerProxy::supportsFullScreen(bool withKeyboard, bool& supports)

Who are the callers of this function? At first glance you wouldn't know that returning false here means "we support keyboard, just none of the alphanumeric keys". It would be nice to clarify that either in the bool param name or the function name.

[Jeremy Jones]

Comment on attachment 341509 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341509&action=review

> Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp:107
> +    supports = false;

This is incorrect. It should be:
supports = !withKeyboard;

[Jeremy Jones]

Created attachment 341804 [details]
Patch

[EWS Watchlist]

Comment on attachment 341804 [details]
Patch

Attachment 341804 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7937783

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html

[EWS Watchlist]

Created attachment 341816 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[WebKit Commit Bot]

Comment on attachment 341804 [details]
Patch

Clearing flags on attachment: 341804

Committed r232471: <https://trac.webkit.org/changeset/232471>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.