Bug 186058 - Disable keyboard in fullscreen ios.
Summary: Disable keyboard in fullscreen ios.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-29 13:34 PDT by Jeremy Jones
Modified: 2018-06-04 10:26 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.42 KB, patch)
2018-05-29 13:37 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff
Patch (1.43 KB, patch)
2018-06-01 16:44 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews200 for win-future (12.92 MB, application/zip)
2018-06-01 19:22 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2018-05-29 13:34:51 PDT
Disable keyboard in fullscreen ios.
Comment 1 Jeremy Jones 2018-05-29 13:35:40 PDT
rdar://problem/36187333
Comment 2 Jeremy Jones 2018-05-29 13:37:03 PDT
Created attachment 341509 [details]
Patch
Comment 3 Ryosuke Niwa 2018-05-29 19:40:07 PDT
Comment on attachment 341509 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341509&action=review

> Source/WebKit/ChangeLog:8
> +        Disallow keyboard in ios fullscreen. This will still allow select keys useful for playback.

Can we add a layout test for this?
Comment 4 Jon Lee 2018-05-30 16:36:42 PDT
Comment on attachment 341509 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341509&action=review

> Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp:104
>  void WebFullScreenManagerProxy::supportsFullScreen(bool withKeyboard, bool& supports)

Who are the callers of this function? At first glance you wouldn't know that returning false here means "we support keyboard, just none of the alphanumeric keys". It would be nice to clarify that either in the bool param name or the function name.
Comment 5 Jeremy Jones 2018-05-31 12:54:02 PDT
Comment on attachment 341509 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341509&action=review

> Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp:107
> +    supports = false;

This is incorrect. It should be:
supports = !withKeyboard;
Comment 6 Jeremy Jones 2018-06-01 16:44:40 PDT
Created attachment 341804 [details]
Patch
Comment 7 EWS Watchlist 2018-06-01 19:22:28 PDT
Comment on attachment 341804 [details]
Patch

Attachment 341804 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7937783

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html
Comment 8 EWS Watchlist 2018-06-01 19:22:39 PDT
Created attachment 341816 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 9 WebKit Commit Bot 2018-06-04 10:26:47 PDT
Comment on attachment 341804 [details]
Patch

Clearing flags on attachment: 341804

Committed r232471: <https://trac.webkit.org/changeset/232471>
Comment 10 WebKit Commit Bot 2018-06-04 10:26:49 PDT
All reviewed patches have been landed.  Closing bug.