Bug 186054 – Avoid unnecessary String allocation in isPublicSuffix(const String&)

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Chris Dumez]

Avoid unnecessary String allocation in isPublicSuffix(const String&):
Sample Count, Samples %, CPU %, Symbol
1, 0.0%, 0.0%, WebCore::ResourceRequestBase::partitionName(WTF::String const&) (in WebCore)
1, 0.0%, 0.0%,     WebCore::topPrivatelyControlledDomain(WTF::String const&) (in WebCore)
1, 0.0%, 0.0%,         WebCore::isPublicSuffix(WTF::String const&) (in WebCore)
1, 0.0%, 0.0%,             WTF::String::String(NSString*) (in JavaScriptCore)
1, 0.0%, 0.0%,                 DYLD-STUB$$objc_msgSend (in CoreFoundation)

[Chris Dumez]

Created attachment 341494 [details]
Patch

[Sam Weinig]

Comment on attachment 341494 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341494&action=review

> Source/WebCore/platform/mac/PublicSuffixMac.mm:39
> -    NSString *host = decodeHostName(domain);
> +    NSString *host = decodeHostName(static_cast<NSString*>(domain));

I would add a comment explaining the cast.

Also, the NSString* should be NSString * (space between NSString and *).  And I think we traditionally use C-style casts for objective-c casts.

[Chris Dumez]

Created attachment 341499 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 341499 [details]
Patch

Clearing flags on attachment: 341499

Committed r232268: <https://trac.webkit.org/changeset/232268>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/40622283>