Avoid unnecessary String allocation in isPublicSuffix(const String&): Sample Count, Samples %, CPU %, Symbol 1, 0.0%, 0.0%, WebCore::ResourceRequestBase::partitionName(WTF::String const&) (in WebCore) 1, 0.0%, 0.0%, WebCore::topPrivatelyControlledDomain(WTF::String const&) (in WebCore) 1, 0.0%, 0.0%, WebCore::isPublicSuffix(WTF::String const&) (in WebCore) 1, 0.0%, 0.0%, WTF::String::String(NSString*) (in JavaScriptCore) 1, 0.0%, 0.0%, DYLD-STUB$$objc_msgSend (in CoreFoundation)
Created attachment 341494 [details] Patch
Comment on attachment 341494 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341494&action=review > Source/WebCore/platform/mac/PublicSuffixMac.mm:39 > - NSString *host = decodeHostName(domain); > + NSString *host = decodeHostName(static_cast<NSString*>(domain)); I would add a comment explaining the cast. Also, the NSString* should be NSString * (space between NSString and *). And I think we traditionally use C-style casts for objective-c casts.
Created attachment 341499 [details] Patch
Comment on attachment 341499 [details] Patch Clearing flags on attachment: 341499 Committed r232268: <https://trac.webkit.org/changeset/232268>
All reviewed patches have been landed. Closing bug.
<rdar://problem/40622283>