RESOLVED FIXED 186053
[JSC] Add Symbol.prototype.description getter 
https://bugs.webkit.org/show_bug.cgi?id=186053
Summary [JSC] Add Symbol.prototype.description getter
Yusuke Suzuki
Reported 2018-05-29 09:15:56 PDT
[JSC] Add Symbol.prototype.description getter
Attachments
Patch (10.21 KB, patch)
2018-05-29 09:19 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-sierra (2.28 MB, application/zip)
2018-05-29 10:34 PDT, EWS Watchlist 		no flags
Details
Patch (13.72 KB, patch)
2018-05-29 10:39 PDT, Yusuke Suzuki 		keith_miller: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-05-29 09:19:43 PDT
Created attachment 341490 [details] Patch
EWS Watchlist
Comment 2 2018-05-29 10:34:54 PDT
Comment on attachment 341490 [details] Patch Attachment 341490 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7845854 New failing tests: js/Object-getOwnPropertyNames.html
EWS Watchlist
Comment 3 2018-05-29 10:34:55 PDT
Created attachment 341496 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Yusuke Suzuki
Comment 4 2018-05-29 10:39:13 PDT
Created attachment 341497 [details] Patch
Yusuke Suzuki
Comment 5 2018-05-31 18:27:02 PDT
Ping?
Keith Miller
Comment 6 2018-06-01 11:54:38 PDT
Comment on attachment 341497 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341497&action=review r=me. > Source/JavaScriptCore/runtime/SymbolPrototype.cpp:78 > +static inline Symbol* tryExtractSymbol(VM& vm, JSValue thisValue) Nit: I don't think you need the static here.
Yusuke Suzuki
Comment 7 2018-06-01 11:57:41 PDT
Comment on attachment 341497 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341497&action=review Thanks >> Source/JavaScriptCore/runtime/SymbolPrototype.cpp:78 >> +static inline Symbol* tryExtractSymbol(VM& vm, JSValue thisValue) > > Nit: I don't think you need the static here. Right. Removed.
Yusuke Suzuki
Comment 8 2018-06-01 12:06:41 PDT
Committed r232404: <https://trac.webkit.org/changeset/232404>
Radar WebKit Bug Importer
Comment 9 2018-06-01 12:12:32 PDT
<rdar://problem/40729879>
Note You need to log in before you can comment on or make changes to this bug.