Bug 186053 - [JSC] Add Symbol.prototype.description getter
Summary: [JSC] Add Symbol.prototype.description getter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-29 09:15 PDT by Yusuke Suzuki
Modified: 2018-06-01 12:12 PDT (History)
7 users (show)

See Also:

Attachments
Patch (10.21 KB, patch)
2018-05-29 09:19 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-sierra (2.28 MB, application/zip)
2018-05-29 10:34 PDT, EWS Watchlist 		no flags Details
Patch (13.72 KB, patch)
2018-05-29 10:39 PDT, Yusuke Suzuki 		keith_miller: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-05-29 09:15:56 PDT 
[JSC] Add Symbol.prototype.description getter
Comment 1 Yusuke Suzuki 2018-05-29 09:19:43 PDT 
Created attachment 341490 [details]
Patch
Comment 2 EWS Watchlist 2018-05-29 10:34:54 PDT 
Comment on attachment 341490 [details]
Patch

Attachment 341490 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7845854

New failing tests:
js/Object-getOwnPropertyNames.html
Comment 3 EWS Watchlist 2018-05-29 10:34:55 PDT 
Created attachment 341496 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 4 Yusuke Suzuki 2018-05-29 10:39:13 PDT 
Created attachment 341497 [details]
Patch
Comment 5 Yusuke Suzuki 2018-05-31 18:27:02 PDT 
Ping?
Comment 6 Keith Miller 2018-06-01 11:54:38 PDT 
Comment on attachment 341497 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341497&action=review

r=me.

> Source/JavaScriptCore/runtime/SymbolPrototype.cpp:78
> +static inline Symbol* tryExtractSymbol(VM& vm, JSValue thisValue)

Nit: I don't think you need the static here.
Comment 7 Yusuke Suzuki 2018-06-01 11:57:41 PDT 
Comment on attachment 341497 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341497&action=review

Thanks

>> Source/JavaScriptCore/runtime/SymbolPrototype.cpp:78
>> +static inline Symbol* tryExtractSymbol(VM& vm, JSValue thisValue)
> 
> Nit: I don't think you need the static here.

Right. Removed.
Comment 8 Yusuke Suzuki 2018-06-01 12:06:41 PDT 
Committed r232404: <https://trac.webkit.org/changeset/232404>
Comment 9 Radar WebKit Bug Importer 2018-06-01 12:12:32 PDT 
<rdar://problem/40729879>