Bug 186043 – Straighten out HTMLInputElement attribute handling

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Darin Adler]

Straighten out HTMLInputElement attribute handling

[Darin Adler]

Created attachment 341471 [details]
Patch

[Darin Adler]

Added recent modifiers of HTMLInputElement to the cc list.

[Daniel Bates]

Comment on attachment 341471 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341471&action=review

> Source/WebCore/ChangeLog:45
> +        fixed a bug: With some work could create a test case to demonstrate that.

The last sentence does not read well.

[Darin Adler]

Committed r232335: <https://trac.webkit.org/changeset/232335>

[Radar WebKit Bug Importer]

<rdar://problem/40674604>

[Dawei Fenton (:realdawei)]

Looks like this patch broke iOS build:

https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20%28Build%29/builds/6238/steps/compile-webkit/logs/stdio

[Ryan Haddad]

(In reply to David Fenton from comment #6)
> Looks like this patch broke iOS build:
> 
> https://build.webkit.org/builders/
> Apple%20iOS%2011%20Simulator%20Release%20%28Build%29/builds/6238/steps/
> compile-webkit/logs/stdio
From the log:

./html/BaseChooserOnlyDateAndTimeInputType.h:44:10: error: 'updateInnerTextValue' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]

[Chris Dumez]

(In reply to Ryan Haddad from comment #7)
> (In reply to David Fenton from comment #6)
> > Looks like this patch broke iOS build:
> > 
> > https://build.webkit.org/builders/
> > Apple%20iOS%2011%20Simulator%20Release%20%28Build%29/builds/6238/steps/
> > compile-webkit/logs/stdio
> From the log:
> 
> ./html/BaseChooserOnlyDateAndTimeInputType.h:44:10: error:
> 'updateInnerTextValue' overrides a member function but is not marked
> 'override' [-Werror,-Winconsistent-missing-override]

I will fix it shortly.

[Chris Dumez]

(In reply to Chris Dumez from comment #8)
> (In reply to Ryan Haddad from comment #7)
> > (In reply to David Fenton from comment #6)
> > > Looks like this patch broke iOS build:
> > > 
> > > https://build.webkit.org/builders/
> > > Apple%20iOS%2011%20Simulator%20Release%20%28Build%29/builds/6238/steps/
> > > compile-webkit/logs/stdio
> > From the log:
> > 
> > ./html/BaseChooserOnlyDateAndTimeInputType.h:44:10: error:
> > 'updateInnerTextValue' overrides a member function but is not marked
> > 'override' [-Werror,-Winconsistent-missing-override]
> 
> I will fix it shortly.

iOS build fixes: <https://trac.webkit.org/changeset/232349>

[Darin Adler]

Thanks for fixing it, Chris.