Bug 186043 - Straighten out HTMLInputElement attribute handling
Summary: Straighten out HTMLInputElement attribute handling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-28 22:20 PDT by Darin Adler
Modified: 2018-05-31 22:41 PDT (History)
9 users (show)

See Also:

Attachments
Patch (50.77 KB, patch)
2018-05-28 22:35 PDT, Darin Adler 		dbates: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2018-05-28 22:20:35 PDT 
Straighten out HTMLInputElement attribute handling
Comment 1 Darin Adler 2018-05-28 22:35:52 PDT 
Created attachment 341471 [details]
Patch
Comment 2 Darin Adler 2018-05-28 23:00:39 PDT 
Added recent modifiers of HTMLInputElement to the cc list.
Comment 3 Daniel Bates 2018-05-29 11:29:20 PDT 
Comment on attachment 341471 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341471&action=review

> Source/WebCore/ChangeLog:45
> +        fixed a bug: With some work could create a test case to demonstrate that.

The last sentence does not read well.
Comment 4 Darin Adler 2018-05-30 21:23:07 PDT 
Committed r232335: <https://trac.webkit.org/changeset/232335>
Comment 5 Radar WebKit Bug Importer 2018-05-30 21:41:20 PDT 
<rdar://problem/40674604>
Comment 7 Ryan Haddad 2018-05-31 09:17:45 PDT 
(In reply to David Fenton from comment #6)
> Looks like this patch broke iOS build:
> 
> https://build.webkit.org/builders/
> Apple%20iOS%2011%20Simulator%20Release%20%28Build%29/builds/6238/steps/
> compile-webkit/logs/stdio
From the log:

./html/BaseChooserOnlyDateAndTimeInputType.h:44:10: error: 'updateInnerTextValue' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
Comment 8 Chris Dumez 2018-05-31 09:20:12 PDT 
(In reply to Ryan Haddad from comment #7)
> (In reply to David Fenton from comment #6)
> > Looks like this patch broke iOS build:
> > 
> > https://build.webkit.org/builders/
> > Apple%20iOS%2011%20Simulator%20Release%20%28Build%29/builds/6238/steps/
> > compile-webkit/logs/stdio
> From the log:
> 
> ./html/BaseChooserOnlyDateAndTimeInputType.h:44:10: error:
> 'updateInnerTextValue' overrides a member function but is not marked
> 'override' [-Werror,-Winconsistent-missing-override]

I will fix it shortly.
Comment 9 Chris Dumez 2018-05-31 09:25:18 PDT 
(In reply to Chris Dumez from comment #8)
> (In reply to Ryan Haddad from comment #7)
> > (In reply to David Fenton from comment #6)
> > > Looks like this patch broke iOS build:
> > > 
> > > https://build.webkit.org/builders/
> > > Apple%20iOS%2011%20Simulator%20Release%20%28Build%29/builds/6238/steps/
> > > compile-webkit/logs/stdio
> > From the log:
> > 
> > ./html/BaseChooserOnlyDateAndTimeInputType.h:44:10: error:
> > 'updateInnerTextValue' overrides a member function but is not marked
> > 'override' [-Werror,-Winconsistent-missing-override]
> 
> I will fix it shortly.

iOS build fixes: <https://trac.webkit.org/changeset/232349>
Comment 10 Darin Adler 2018-05-31 22:41:32 PDT 
Thanks for fixing it, Chris.