Bug 186042 – [Extra zoom mode] "Significant area painted" rendering progress event is rarely fired

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Wenson Hsieh]

<rdar://problem/40604182>

[Wenson Hsieh]

Created attachment 341465 [details]
Patch

[Wenson Hsieh]

Created attachment 341467 [details]
Fix macOS build

[Tim Horton]

Comment on attachment 341467 [details]
Fix macOS build

View in context: https://bugs.webkit.org/attachment.cgi?id=341467&action=review

> Source/WebCore/page/Page.cpp:1863
> +    relevantViewRectWidth = std::min<float>(viewRect.width().toFloat(), relevantViewRectWidth);

Likely we should consider doing this everywhere at some point.

> Tools/TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:58
> +@implementation RenderingProgressHandler {
> +    BlockPtr<void(_WKRenderingProgressEvents)> _handler;
> +}

If you use TestNavigationDelegate, you can get rid of this class entirely.

[Wenson Hsieh]

Comment on attachment 341467 [details]
Fix macOS build

View in context: https://bugs.webkit.org/attachment.cgi?id=341467&action=review

>> Source/WebCore/page/Page.cpp:1863
>> +    relevantViewRectWidth = std::min<float>(viewRect.width().toFloat(), relevantViewRectWidth);
> 
> Likely we should consider doing this everywhere at some point.

Indeed. Filed https://bugs.webkit.org/show_bug.cgi?id=186051 (and added a FIXME).

>> Tools/TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:58
>> +}
> 
> If you use TestNavigationDelegate, you can get rid of this class entirely.

Good point!

[Wenson Hsieh]

Created attachment 341486 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 341486 [details]
Patch for landing

Clearing flags on attachment: 341486

Committed r232256: <https://trac.webkit.org/changeset/232256>