Bug 186042 - [Extra zoom mode] "Significant area painted" rendering progress event is rarely fired
Summary: [Extra zoom mode] "Significant area painted" rendering progress event is rare...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-28 19:13 PDT by Wenson Hsieh
Modified: 2018-05-30 17:25 PDT (History)
6 users (show)

See Also:

Attachments
Patch (17.08 KB, patch)
2018-05-28 19:31 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Fix macOS build (17.19 KB, patch)
2018-05-28 20:39 PDT, Wenson Hsieh 		thorton: review+
Details | Formatted Diff | Diff
Patch for landing (16.75 KB, patch)
2018-05-29 07:21 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-05-28 19:13:27 PDT 
<rdar://problem/40604182>
Comment 1 Wenson Hsieh 2018-05-28 19:31:24 PDT 
Created attachment 341465 [details]
Patch
Comment 2 Wenson Hsieh 2018-05-28 20:39:03 PDT 
Created attachment 341467 [details]
Fix macOS build
Comment 3 Tim Horton 2018-05-28 23:03:38 PDT 
Comment on attachment 341467 [details]
Fix macOS build

View in context: https://bugs.webkit.org/attachment.cgi?id=341467&action=review

> Source/WebCore/page/Page.cpp:1863
> +    relevantViewRectWidth = std::min<float>(viewRect.width().toFloat(), relevantViewRectWidth);

Likely we should consider doing this everywhere at some point.

> Tools/TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:58
> +@implementation RenderingProgressHandler {
> +    BlockPtr<void(_WKRenderingProgressEvents)> _handler;
> +}

If you use TestNavigationDelegate, you can get rid of this class entirely.
Comment 4 Wenson Hsieh 2018-05-29 07:18:13 PDT 
Comment on attachment 341467 [details]
Fix macOS build

View in context: https://bugs.webkit.org/attachment.cgi?id=341467&action=review

>> Source/WebCore/page/Page.cpp:1863
>> +    relevantViewRectWidth = std::min<float>(viewRect.width().toFloat(), relevantViewRectWidth);
> 
> Likely we should consider doing this everywhere at some point.

Indeed. Filed https://bugs.webkit.org/show_bug.cgi?id=186051 (and added a FIXME).

>> Tools/TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:58
>> +}
> 
> If you use TestNavigationDelegate, you can get rid of this class entirely.

Good point!
Comment 5 Wenson Hsieh 2018-05-29 07:21:24 PDT 
Created attachment 341486 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2018-05-29 08:00:15 PDT 
Comment on attachment 341486 [details]
Patch for landing

Clearing flags on attachment: 341486

Committed r232256: <https://trac.webkit.org/changeset/232256>