Bug 186041 - Expose additional WKMenuItemIdentifier strings
Summary: Expose additional WKMenuItemIdentifier strings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeff Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-28 16:07 PDT by Jeff Miller
Modified: 2018-05-29 11:11 PDT (History)
3 users (show)

See Also:

Attachments
Patch (7.98 KB, patch)
2018-05-28 17:54 PDT, Jeff Miller 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Miller 2018-05-28 16:07:25 PDT 
Expose additional WKMenuItemIdentifier strings.
Comment 1 Radar WebKit Bug Importer 2018-05-28 16:07:53 PDT 
<rdar://problem/40602613>
Comment 2 Jeff Miller 2018-05-28 16:23:20 PDT 
Specifically:

_WKMenuItemIdentifierCopyMediaLink
_WKMenuItemIdentifierDownloadMedia
_WKMenuItemIdentifierOpenMediaInNewWindow
_WKMenuItemIdentifierOpenWithDefaultApplication
_WKMenuItemIdentifierPDFActualSize
_WKMenuItemIdentifierPDFAutoSize
_WKMenuItemIdentifierPDFFacingPages
_WKMenuItemIdentifierPDFFacingPagesScolling
_WKMenuItemIdentifierPDFNextPage
_WKMenuItemIdentifierPDFPreviousPage
_WKMenuItemIdentifierPDFSinglePage
_WKMenuItemIdentifierPDFSinglePageScrolling
_WKMenuItemIdentifierPDFZoomIn
_WKMenuItemIdentifierPDFZoomOut
_WKMenuItemIdentifierToggleEnhancedFullScreen
Comment 3 Jeff Miller 2018-05-28 17:40:18 PDT 
Tim Horton says there's no need to support the legacy WebPDFView, so we don't have to worry about PDF-related menu items since those are all managed by PDFKit. So the list of additional identifiers we need is just:

_WKMenuItemIdentifierCopyMediaLink
_WKMenuItemIdentifierDownloadMedia
_WKMenuItemIdentifierOpenMediaInNewWindow
_WKMenuItemIdentifierToggleEnhancedFullScreen
Comment 4 Jeff Miller 2018-05-28 17:54:00 PDT 
Created attachment 341461 [details]
Patch
Comment 5 Jeff Miller 2018-05-29 11:11:35 PDT 
Committed https://trac.webkit.org/changeset/232266/webkit