RESOLVED FIXED 186041
Expose additional WKMenuItemIdentifier strings 
https://bugs.webkit.org/show_bug.cgi?id=186041
Summary Expose additional WKMenuItemIdentifier strings
Jeff Miller
Reported 2018-05-28 16:07:25 PDT
Expose additional WKMenuItemIdentifier strings.
Attachments
Patch (7.98 KB, patch)
2018-05-28 17:54 PDT, Jeff Miller 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-05-28 16:07:53 PDT
<rdar://problem/40602613>
Jeff Miller
Comment 2 2018-05-28 16:23:20 PDT
Specifically: _WKMenuItemIdentifierCopyMediaLink _WKMenuItemIdentifierDownloadMedia _WKMenuItemIdentifierOpenMediaInNewWindow _WKMenuItemIdentifierOpenWithDefaultApplication _WKMenuItemIdentifierPDFActualSize _WKMenuItemIdentifierPDFAutoSize _WKMenuItemIdentifierPDFFacingPages _WKMenuItemIdentifierPDFFacingPagesScolling _WKMenuItemIdentifierPDFNextPage _WKMenuItemIdentifierPDFPreviousPage _WKMenuItemIdentifierPDFSinglePage _WKMenuItemIdentifierPDFSinglePageScrolling _WKMenuItemIdentifierPDFZoomIn _WKMenuItemIdentifierPDFZoomOut _WKMenuItemIdentifierToggleEnhancedFullScreen
Jeff Miller
Comment 3 2018-05-28 17:40:18 PDT
Tim Horton says there's no need to support the legacy WebPDFView, so we don't have to worry about PDF-related menu items since those are all managed by PDFKit. So the list of additional identifiers we need is just: _WKMenuItemIdentifierCopyMediaLink _WKMenuItemIdentifierDownloadMedia _WKMenuItemIdentifierOpenMediaInNewWindow _WKMenuItemIdentifierToggleEnhancedFullScreen
Jeff Miller
Comment 4 2018-05-28 17:54:00 PDT
Created attachment 341461 [details] Patch
Jeff Miller
Comment 5 2018-05-29 11:11:35 PDT
Committed https://trac.webkit.org/changeset/232266/webkit
Note You need to log in before you can comment on or make changes to this bug.