Bug 186020 – [JSC] Remove ENABLE_INTL flag

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: New Bugs

[Yusuke Suzuki]

[JSC] Remove ENABLE_INTL flag

[Yusuke Suzuki]

Created attachment 341422 [details]
Patch

[Yusuke Suzuki]

This patch enables AppleWin's INTL feature. I'm not sure why this is disabled for AppleWin.

[Yusuke Suzuki]

@bfulgham, @achristensen do you know why AppleWin do not support ENABLE(INTL)?

[Olivier Blin]

ENABLE(INTL) requires at least udat and unum support in ICU.
We usually do not enable this in the ICU library that we ship in our embedded devices (set-top box), used by QtWebKit and WPE.
udat and unum resources make the ICU library much bigger.

[Michael Catanzaro]

I guess I'd favor keeping the flag forever, then, if we're OK with doing that. And making it PUBLIC for WPE.

We should definitely remove it if we do not make it PUBLIC in at least one port.

[Michael Catanzaro]

Comment on attachment 341422 [details]
Patch

r- for now, we can either discuss further, or make it public for WPE and move on.

[Yusuke Suzuki]

(In reply to Michael Catanzaro from comment #6)
> Comment on attachment 341422 [details]
> Patch
> 
> r- for now, we can either discuss further, or make it public for WPE and
> move on.

Hm, it's sad. Can we build ICU with udat & unum with empty data?
If we can do that, we can remove ENABLE(INTL) things while we can keep ICU small.

[Olivier Blin]

(In reply to Yusuke Suzuki from comment #7)

> Hm, it's sad. Can we build ICU with udat & unum with empty data?
> If we can do that, we can remove ENABLE(INTL) things while we can keep ICU
> small.

Yes, I have to check this, I agree it would be best.
IIRC, it was difficult with older ICU releases, but it's probaly different now.

[Michael Catanzaro]

*** Bug 178663 has been marked as a duplicate of this bug. ***

[Ross Kirsling]

*** This bug has been marked as a duplicate of bug 210164 ***