Bug 186018 - [LFC] Add layout tree verification.
Summary: [LFC] Add layout tree verification.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-27 07:43 PDT by zalan
Modified: 2018-05-28 10:56 PDT (History)
6 users (show)

See Also:


Attachments
Patch (22.08 KB, patch)
2018-05-27 08:02 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (22.04 KB, patch)
2018-05-28 09:46 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (21.99 KB, patch)
2018-05-28 10:15 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-05-27 07:43:08 PDT
Compare with the render tree geometry and output the mismatched rectangles.
Comment 1 zalan 2018-05-27 08:02:40 PDT
Created attachment 341421 [details]
Patch
Comment 2 zalan 2018-05-28 09:46:08 PDT
Created attachment 341456 [details]
Patch
Comment 3 Antti Koivisto 2018-05-28 10:00:51 PDT
Comment on attachment 341456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341456&action=review

> Source/WebCore/layout/Verification.cpp:44
> +    auto outputRect = [&stream, &renderer, &layoutBox, &firstMismatchingRect] (const String& prefix, const LayoutRect& rendererRect, const LayoutRect& layoutRect) {

Maybe just [&]?
Comment 4 zalan 2018-05-28 10:15:37 PDT
Created attachment 341457 [details]
Patch
Comment 5 WebKit Commit Bot 2018-05-28 10:55:23 PDT
Comment on attachment 341457 [details]
Patch

Clearing flags on attachment: 341457

Committed r232248: <https://trac.webkit.org/changeset/232248>
Comment 6 WebKit Commit Bot 2018-05-28 10:55:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-05-28 10:56:26 PDT
<rdar://problem/40600664>