Bug 186016 – [Cocoa] Avoid importing directly from subumbrella frameworks

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

Import umbrella frameworks’ umbrella headers and link against the umbrella frameworks rather than adding the umbrellas’ Frameworks directory to the frameworks search paths and importing subumbrellas directly.

Created attachment 341411 [details]
Patch to see if anything breaks

Created attachment 341412 [details]
Patch to see if anything breaks

Created attachment 341435 [details]
Patch to see if anything breaks

Created attachment 341437 [details]
Patch to see if anything breaks

Created attachment 341439 [details]
Import umbrella framework headers

Committed <https://trac.webkit.org/r232235> with additional changes for the USE(APPLE_INTERNAL_SDK) build.

[Radar WebKit Bug Importer]

<rdar://problem/40591038>

Tried to fix the 32-bit USE(APPLE_INTERNAL_SDK) build in <https://trac.webkit.org/r232237>.

Tried to fix the pre-High Sierra USE(APPLE_INTERNAL_SDK) build in <https://trac.webkit.org/r232238>.

ApplicationServicesPriv.h is wreaking havoc in Sierra builds. I am going to undo all the changes for now and perhaps attempt this again when Sierra doesn’t need to be supported.

(In reply to mitz from comment #10)
> ApplicationServicesPriv.h is wreaking havoc in Sierra builds. I am going to
> undo all the changes for now and perhaps attempt this again when Sierra
> doesn’t need to be supported.

Reverted everything in <https://trac.webkit.org/r232239>.

Created attachment 358025 [details]
Updated version for when macOS 10.12 is no longer supported

[WebKit Commit Bot]

Comment on attachment 358025 [details]
Updated version for when macOS 10.12 is no longer supported

Clearing flags on attachment: 358025

Committed r239901: <https://trac.webkit.org/changeset/239901>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

(In reply to WebKit Commit Bot from comment #13)
> Comment on attachment 358025 [details]
> Updated version for when macOS 10.12 is no longer supported
> 
> Clearing flags on attachment: 358025
> 
> Committed r239901: <https://trac.webkit.org/changeset/239901>

Tried to fix USE(APPLE_INTERNAL_SDK) builds in <https://trac.webkit.org/r239909>.

(In reply to mitz from comment #15)
> (In reply to WebKit Commit Bot from comment #13)
> > Comment on attachment 358025 [details]
> > Updated version for when macOS 10.12 is no longer supported
> > 
> > Clearing flags on attachment: 358025
> > 
> > Committed r239901: <https://trac.webkit.org/changeset/239901>
> 
> Tried to fix USE(APPLE_INTERNAL_SDK) builds in
> <https://trac.webkit.org/r239909>.

…and in <https://trac.webkit.org/r239910>.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 193407

Committed <https://trac.webkit.org/r240211>.