Bug 186011 - iOS WK1: Occasional crash in sanitizedMarkupForFragmentInDocument
Summary: iOS WK1: Occasional crash in sanitizedMarkupForFragmentInDocument
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-26 00:17 PDT by Ryosuke Niwa
Modified: 2018-05-29 13:30 PDT (History)
6 users (show)

See Also:

Attachments
Fixes the bug (5.41 KB, patch)
2018-05-26 01:55 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-05-26 00:17:22 PDT 
We're seeing an occasional crash inside appendChild in sanitizedMarkupForFragmentInDocument.
Comment 1 Ryosuke Niwa 2018-05-26 01:55:39 PDT 
Created attachment 341392 [details]
Fixes the bug
Comment 2 Ryosuke Niwa 2018-05-26 01:57:29 PDT 
<rdar://problem/36256359>
Comment 3 Alexey Proskuryakov 2018-05-26 12:12:09 PDT 
Interesting!

When what the yielding added? It would seem that it may be required for responsiveness. Perhaps we don’t care about WK1 responsiveness any more though.
Comment 4 Ryosuke Niwa 2018-05-29 12:53:14 PDT 
(In reply to Alexey Proskuryakov from comment #3)
> Interesting!
> 
> When what the yielding added? It would seem that it may be required for
> responsiveness. Perhaps we don’t care about WK1 responsiveness any more
> though.

Well, we're creating an empty document here, and we're in the middle of trying to paste a content, which is a sync API so we can't really yield.
Comment 5 David Kilzer (:ddkilzer) 2018-05-29 12:54:58 PDT 
Comment on attachment 341392 [details]
Fixes the bug

r=me
Comment 6 WebKit Commit Bot 2018-05-29 13:30:23 PDT 
Comment on attachment 341392 [details]
Fixes the bug

Clearing flags on attachment: 341392

Committed r232272: <https://trac.webkit.org/changeset/232272>
Comment 7 WebKit Commit Bot 2018-05-29 13:30:25 PDT 
All reviewed patches have been landed.  Closing bug.