Bug 18601 - Add the UI portions of the Scripts panel
Summary: Add the UI portions of the Scripts panel
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Blocker
Assignee: Timothy Hatcher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-18 15:08 PDT by Timothy Hatcher
Modified: 2008-04-21 14:15 PDT (History)
1 user (show)

See Also:


Attachments
Initial UI portions of the Scripts panel (72.53 KB, patch)
2008-04-18 15:14 PDT, Timothy Hatcher
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2008-04-18 15:08:57 PDT
The UI refresh did not add the Scripts panel. This bug tracks landing the UI portions of the Scripts panel.
Comment 1 Timothy Hatcher 2008-04-18 15:14:12 PDT
Created attachment 20678 [details]
Initial UI portions of the Scripts panel
Comment 2 Adam Roben (:aroben) 2008-04-21 11:27:04 PDT
Comment on attachment 20678 [details]
Initial UI portions of the Scripts panel

Can we change any existing UI separately from landing new UI/behavior?
Comment 3 Adam Roben (:aroben) 2008-04-21 11:36:22 PDT
Comment on attachment 20678 [details]
Initial UI portions of the Scripts panel

+    this.pauseButton.appendChild(document.createElement("img"));

Why do we need these <img> elements? Can we just set content: on the <button>? Maybe the <img> is needed to autosize the button?

+#scripts-sidebar-resizer-widget {
+    position: absolute;
+    top: 0;
+    bottom: 0;
+    right: 225px;
+	width: 16px;
+	cursor: col-resize;
+	background-image: url(Images/statusbarResizerHorizontal.png);
+	background-repeat: no-repeat;
+	background-position: center;
+}

Looks like indentation got screwy here.

r=me, but I do think it would be good to split out the changes to existing UI from the new stuff and land them first.
Comment 4 Timothy Hatcher 2008-04-21 14:07:20 PDT
(In reply to comment #3)
> (From update of attachment 20678 [details] [edit])
> +    this.pauseButton.appendChild(document.createElement("img"));
> 
> Why do we need these <img> elements? Can we just set content: on the <button>?
> Maybe the <img> is needed to autosize the button?

I guess we could use generated content for this. It was just easier to do with an image 

> +#scripts-sidebar-resizer-widget {
> +    position: absolute;
> +    top: 0;
> +    bottom: 0;
> +    right: 225px;
> +       width: 16px;
> +       cursor: col-resize;
> +       background-image: url(Images/statusbarResizerHorizontal.png);
> +       background-repeat: no-repeat;
> +       background-position: center;
> +}
> 
> Looks like indentation got screwy here.

I fixed this.
Comment 5 Timothy Hatcher 2008-04-21 14:13:09 PDT
Fixed in r32343.
Comment 6 Adam Roben (:aroben) 2008-04-21 14:15:43 PDT
(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 20678 [details] [edit] [edit])
> > +    this.pauseButton.appendChild(document.createElement("img"));
> > 
> > Why do we need these <img> elements? Can we just set content: on the <button>?
> > Maybe the <img> is needed to autosize the button?
> 
> I guess we could use generated content for this. It was just easier to do with
> an image 

You already are using generated content, it looks like:

+#scripts-step-out img {
+    content: url(Images/debuggerStepOut.png);
+}