Bug 186006 – [ESNext][BigInt] Skip BigInt div tests breaking on iOS build

• Status: RESOLVED
• Resolution: INVALID
• Component: JavaScriptCore

[Caio Lima]

Some tests are breaking on IOS build and we should skip such tests.

[Caio Lima]

Created attachment 341373 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 341373 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341373&action=review

> JSTests/ChangeLog:10
> +
> +        Skippping big-int-div tests on iOS build because they are broken in
> +        this architecture.
> +

I think we should fix this issue rather than disabling this only for iOS platforms.

[Caio Lima]

Comment on attachment 341373 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341373&action=review

>> JSTests/ChangeLog:10
>> +
> 
> I think we should fix this issue rather than disabling this only for iOS platforms.

I agree. The problem is that it seems to be a internal build and I don't have access to the error trace. I can't find these tests failing into build.webkit.org. Could anyone help me get the error trace, if possible?

[Yusuke Suzuki]

Comment on attachment 341373 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341373&action=review

>>> JSTests/ChangeLog:10
>>> +
>> 
>> I think we should fix this issue rather than disabling this only for iOS platforms.
> 
> I agree. The problem is that it seems to be a internal build and I don't have access to the error trace. I can't find these tests failing into build.webkit.org. Could anyone help me get the error trace, if possible?

It seems that digitDiv's generic path is broken. I commented out X86 / X86_64 asm part, and even x86_64 Linux shows failures.

[Caio Lima]

(In reply to Yusuke Suzuki from comment #4)
> Comment on attachment 341373 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=341373&action=review
> 
> >>> JSTests/ChangeLog:10
> >>> +
> >> 
> >> I think we should fix this issue rather than disabling this only for iOS platforms.
> > 
> > I agree. The problem is that it seems to be a internal build and I don't have access to the error trace. I can't find these tests failing into build.webkit.org. Could anyone help me get the error trace, if possible?
> 
> It seems that digitDiv's generic path is broken. I commented out X86 /
> X86_64 asm part, and even x86_64 Linux shows failures.

Thx! This way, I think we should Rollback https://trac.webkit.org/changeset/231886. The problem is that I'm unable to do that until tomorrow night. I will do that ASAP.

[Alexey Proskuryakov]

cf. rdar://problem/40331121