Bug 186006 - [ESNext][BigInt] Skip BigInt div tests breaking on iOS build
Summary: [ESNext][BigInt] Skip BigInt div tests breaking on iOS build
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Lima
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-25 17:18 PDT by Caio Lima
Modified: 2018-05-27 11:09 PDT (History)
8 users (show)

See Also:

Attachments
Patch (3.90 KB, patch)
2018-05-25 18:33 PDT, Caio Lima 		ysuzuki: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Lima 2018-05-25 17:18:19 PDT 
Some tests are breaking on IOS build and we should skip such tests.
Comment 1 Caio Lima 2018-05-25 18:33:18 PDT 
Created attachment 341373 [details]
Patch
Comment 2 Yusuke Suzuki 2018-05-26 09:14:40 PDT 
Comment on attachment 341373 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341373&action=review

> JSTests/ChangeLog:10
> +
> +        Skippping big-int-div tests on iOS build because they are broken in
> +        this architecture.
> +

I think we should fix this issue rather than disabling this only for iOS platforms.
Comment 3 Caio Lima 2018-05-26 09:29:44 PDT 
Comment on attachment 341373 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341373&action=review

>> JSTests/ChangeLog:10
>> +
> 
> I think we should fix this issue rather than disabling this only for iOS platforms.

I agree. The problem is that it seems to be a internal build and I don't have access to the error trace. I can't find these tests failing into build.webkit.org. Could anyone help me get the error trace, if possible?
Comment 4 Yusuke Suzuki 2018-05-26 10:25:15 PDT 
Comment on attachment 341373 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341373&action=review

>>> JSTests/ChangeLog:10
>>> +
>> 
>> I think we should fix this issue rather than disabling this only for iOS platforms.
> 
> I agree. The problem is that it seems to be a internal build and I don't have access to the error trace. I can't find these tests failing into build.webkit.org. Could anyone help me get the error trace, if possible?

It seems that digitDiv's generic path is broken. I commented out X86 / X86_64 asm part, and even x86_64 Linux shows failures.
Comment 5 Caio Lima 2018-05-26 12:32:04 PDT 
(In reply to Yusuke Suzuki from comment #4)
> Comment on attachment 341373 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=341373&action=review
> 
> >>> JSTests/ChangeLog:10
> >>> +
> >> 
> >> I think we should fix this issue rather than disabling this only for iOS platforms.
> > 
> > I agree. The problem is that it seems to be a internal build and I don't have access to the error trace. I can't find these tests failing into build.webkit.org. Could anyone help me get the error trace, if possible?
> 
> It seems that digitDiv's generic path is broken. I commented out X86 /
> X86_64 asm part, and even x86_64 Linux shows failures.

Thx! This way, I think we should Rollback https://trac.webkit.org/changeset/231886. The problem is that I'm unable to do that until tomorrow night. I will do that ASAP.
Comment 6 Alexey Proskuryakov 2018-05-26 18:48:51 PDT 
cf. rdar://problem/40331121