Bug 186003 - Do even fewer allocations in URL host operations
Summary: Do even fewer allocations in URL host operations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-25 16:16 PDT by Alex Christensen
Modified: 2018-05-29 21:50 PDT (History)
8 users (show)

See Also:

Attachments
Patch (4.84 KB, patch)
2018-05-25 16:19 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-05-25 16:16:24 PDT 
Do even fewer allocations in URL host operations
Comment 1 Alex Christensen 2018-05-25 16:19:15 PDT 
Created attachment 341348 [details]
Patch
Comment 2 Geoffrey Garen 2018-05-25 16:19:52 PDT 
Comment on attachment 341348 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2018-05-29 11:24:58 PDT 
Comment on attachment 341348 [details]
Patch

Clearing flags on attachment: 341348

Committed r232267: <https://trac.webkit.org/changeset/232267>
Comment 4 WebKit Commit Bot 2018-05-29 11:25:00 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-05-29 11:25:30 PDT 
<rdar://problem/40621951>
Comment 6 Darin Adler 2018-05-29 21:50:27 PDT 
Comment on attachment 341348 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341348&action=review

> Source/WebCore/loader/ResourceLoadStatistics.cpp:341
>      if (host.isNull() || host.isEmpty())

The isNull check here is redundant.