Bug 185997 - [Cocoa]: Remove what appears to be a stale mbmalloc target
Summary: [Cocoa]: Remove what appears to be a stale mbmalloc target
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-25 14:51 PDT by Joseph Pecoraro
Modified: 2018-07-16 16:58 PDT (History)
3 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (13.71 KB, patch)
2018-05-25 14:54 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2018-05-25 14:51:19 PDT 
Remove what appears to be a stale mbmalloc target

• Attempting to build this target fails to link due to missing Foundation symbols
• It looks like the PerformanceTools/MallocBench Xcode project has a mbmalloc target which does build and work
Comment 1 Joseph Pecoraro 2018-05-25 14:54:17 PDT 
Created attachment 341331 [details]
[PATCH] Proposed Fix

I'm able to do things without this target... but I'll do a bit more qualification before toggling that cq flag.
Comment 2 Joseph Pecoraro 2018-05-25 17:34:43 PDT 
Ahh, so I see some build commands for linux ports, but I'm not sure this it actually makes sense still. Is there an advantage to the mbmalloc in bmalloc versus the mbmalloc in MallocBench? They seem to produce the same build product, so I suspect only 1 should actually be around.
Comment 3 Darin Adler 2018-05-28 20:32:44 PDT 
Comment on attachment 341331 [details]
[PATCH] Proposed Fix

Looks like you need to remove mbmalloc.cpp from bmalloc/CMakeLists.txt too.

There’s also some mbmalloc stuff in the WTF Xcode project.
Comment 4 Joseph Pecoraro 2018-05-29 10:57:39 PDT 
Apparently this is not stale. Closing the bug.

• The mbmalloc.dylib produced here uses bmalloc.
• The mbmalloc.dylib produced by MallocBench uses the system malloc.
Comment 5 Geoffrey Garen 2018-05-29 11:26:01 PDT 
Maybe we should clean this up by moving the mbmalloc targets from MallocBench and bmalloc into separate projects inside PerformanceTests/MallocBench. The point of mbmalloc is to be a shim around a given malloc implementation. So, you could think of it as a feature of MallocBench that it includes sub-projects that can shim around different mallocs. For example, if we wanted MallocBench to test JEMalloc or TCMalloc, we would need to write additional mbmalloc shims.