Bug 185994 – [mac Debug wk2] Layout Test fast/text/user-installed-fonts/shadow-family.html and fast/text/user-installed-fonts/shadow-postscript-family.html are flaky

• Status: REOPENED
• Component: Tools / Tests

[Dawei Fenton (:realdawei)]

The following layout test is flaky on mac Sierra Debug WK2

fast/text/user-installed-fonts/shadow-family.html

Probable Cause: Unknown, it started on 5/3/2018

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Ftext%2Fuser-installed-fonts%2Fshadow-family.html

[Dawei Fenton (:realdawei)]

Created attachment 341330 [details]
Patch

[Dawei Fenton (:realdawei)]

Actually both fast/text/user-installed-fonts/shadow-family.html and fast/text/user-installed-fonts/shadow-postscript-family.html are flaky on mac Debug Wk2.  

They yield the same images diff results and so are likely related.

https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r232190%20(6600)/results.html

[Dawei Fenton (:realdawei)]

Created attachment 341340 [details]
Patch

[Dawei Fenton (:realdawei)]

Created attachment 341347 [details]
Patch

[Ryan Haddad]

Marked tests as flaky in https://trac.webkit.org/r232213

[Alexey Proskuryakov]

We get a black rectangle as expected image, and a large letter as actual.

[Radar WebKit Bug Importer]

<rdar://problem/40582929>

[Myles C. Maxfield]

Both of these tests install a user-installed font with the same name as a preinstalled font, and test that the user-installed font gets used when content asks for that (shared) name. I assumed this was well-defined, but it is totally possible that this isn't well-defined.

Failing either of these two tests is not indicative of a privacy leak.

[Shawn Roberts]

Test is now flaky in Mojave Release WK2.

[Shawn Roberts]

Updating test expectations for Mac WK2

[Shawn Roberts]

Created attachment 361685 [details]
Update TestExpectations

[WebKit Commit Bot]

Comment on attachment 361685 [details]
Update TestExpectations

Rejecting attachment 361685 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 361685, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: https://webkit-queues.webkit.org/results/11110699

[Shawn Roberts]

Created attachment 361729 [details]
Update TestExpectations

[WebKit Commit Bot]

Comment on attachment 361729 [details]
Update TestExpectations

Clearing flags on attachment: 361729

Committed r241286: <https://trac.webkit.org/changeset/241286>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

(In reply to WebKit Commit Bot from comment #14)
> Comment on attachment 361729 [details]
> Update TestExpectations
> 
> Clearing flags on attachment: 361729
> 
> Committed r241286: <https://trac.webkit.org/changeset/241286>
Reopening since this change only updated test expectations.