Bug 185992 – WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback() unexpectedly constructs a process pool

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback() unexpectedly constructs a process pool:
Sample Count, Samples %, CPU %, Symbol
14, 0.1%, 0.1%, WebKit::WebsiteDataStore::setResourceLoadStatisticsEnabled(bool) (in WebKit)
14, 0.1%, 0.1%,     WebKit::WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback(WTF::Function<void (WTF::String const&)>&&) (in WebKit)
14, 0.1%, 0.1%,         WebKit::WebsiteDataStore::processPools(unsigned long, bool) const (in WebKit)
12, 0.1%, 0.1%,             WebKit::WebProcessPool::create(API::ProcessPoolConfiguration&) (in WebKit)

[Chris Dumez]

Created attachment 341318 [details]
Patch

[John Wilander]

Did you test so that this doesn't turn off the feature in the cases where we expect it to be turned on?

[Chris Dumez]

(In reply to John Wilander from comment #2)
> Did you test so that this doesn't turn off the feature in the cases where we
> expect it to be turned on?

If I add logging in the WebProcess and launch Safari I see:
WebProcess::setResourceLoadStatisticsEnabled(1)

So the feature still gets enabled.

[Geoffrey Garen]

Comment on attachment 341318 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 341318 [details]
Patch

Clearing flags on attachment: 341318

Committed r232203: <https://trac.webkit.org/changeset/232203>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/40566386>