WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
185992
WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback() unexpectedly constructs a process pool
https://bugs.webkit.org/show_bug.cgi?id=185992
Summary
WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback() unexpec...
Chris Dumez
Reported
2018-05-25 13:23:54 PDT
WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback() unexpectedly constructs a process pool: Sample Count, Samples %, CPU %, Symbol 14, 0.1%, 0.1%, WebKit::WebsiteDataStore::setResourceLoadStatisticsEnabled(bool) (in WebKit) 14, 0.1%, 0.1%, WebKit::WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback(WTF::Function<void (WTF::String const&)>&&) (in WebKit) 14, 0.1%, 0.1%, WebKit::WebsiteDataStore::processPools(unsigned long, bool) const (in WebKit) 12, 0.1%, 0.1%, WebKit::WebProcessPool::create(API::ProcessPoolConfiguration&) (in WebKit)
Attachments
Patch
(4.09 KB, patch)
2018-05-25 13:27 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2018-05-25 13:27:25 PDT
Created
attachment 341318
[details]
Patch
John Wilander
Comment 2
2018-05-25 13:49:44 PDT
Did you test so that this doesn't turn off the feature in the cases where we expect it to be turned on?
Chris Dumez
Comment 3
2018-05-25 13:58:30 PDT
(In reply to John Wilander from
comment #2
)
> Did you test so that this doesn't turn off the feature in the cases where we > expect it to be turned on?
If I add logging in the WebProcess and launch Safari I see: WebProcess::setResourceLoadStatisticsEnabled(1) So the feature still gets enabled.
Geoffrey Garen
Comment 4
2018-05-25 14:19:35 PDT
Comment on
attachment 341318
[details]
Patch r=me
WebKit Commit Bot
Comment 5
2018-05-25 14:35:35 PDT
Comment on
attachment 341318
[details]
Patch Clearing flags on attachment: 341318 Committed
r232203
: <
https://trac.webkit.org/changeset/232203
>
WebKit Commit Bot
Comment 6
2018-05-25 14:35:36 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7
2018-05-25 14:38:08 PDT
<
rdar://problem/40566386
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug