Bug 185989 – JavaScriptCore: Disable 32-bit JIT on Windows

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Michael Saboff]

This code is not being maintained. For some 32 bit apps, the JIT doesn't provide a performance benefit.  Disabling the JIT will also save memory.

[Michael Saboff]

<rdar://problem/40343776>

[Michael Saboff]

Created attachment 341312 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 341312 [details]
Patch

Clearing flags on attachment: 341312

Committed r232212: <https://trac.webkit.org/changeset/232212>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Michael Saboff]

This change broke the Win32 build.

[Michael Saboff]

Created attachment 341801 [details]
Updated Patch

[EWS Watchlist]

Attachment 341801 [details] did not pass style-queue:


ERROR: Source/WTF/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Michael Saboff]

Created attachment 341802 [details]
Updated Patch

[Mark Lam]

Comment on attachment 341802 [details]
Updated Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341802&action=review

r=me if the EWS bots are happy.

> Source/JavaScriptCore/ChangeLog:8
> +        Made various minor fixes.

I think you should mention that these fixes are so that the CLOOP can work when COMPUTED_GOTOs is not supported.

> Source/JavaScriptCore/ChangeLog:13
> +        * llint/LowLevelInterpreter.cpp: Changed the definition of OFFLINE_ASM_GLOBAL_LABEL to not
> +        have a case label these aren't opcodes.

Did you mean "... case label because these aren't opcodes"?

[EWS Watchlist]

Comment on attachment 341802 [details]
Updated Patch

Attachment 341802 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7938086

New failing tests:
js/slow-stress/emscripten-memops.html
workers/bomb.html
js/dom/line-column-numbers.html
js/regexp-zero-length-alternatives.html
fast/workers/worker-document-leak.html
accessibility/accessibility-node-memory-management.html
storage/indexeddb/modern/leak-1.html

[EWS Watchlist]

Created attachment 341822 [details]
Archive of layout-test-results from ews201 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Michael Saboff]

(In reply to Build Bot from comment #10)
> Comment on attachment 341802 [details]
> Updated Patch
> 
> Attachment 341802 [details] did not pass win-ews (win):
> Output: http://webkit-queues.webkit.org/results/7938086
> 
> New failing tests:
...
> js/regexp-zero-length-alternatives.html
...

The failure of js/regexp-zero-length-alternatives.html is being tracked in https://bugs.webkit.org/show_bug.cgi?id=186477

[Michael Saboff]

Committed r232719: <https://trac.webkit.org/changeset/232719>