RESOLVED FIXED185983
[Wi-Fi Assertions] Track whether WiFiAssertionHolder should actually hold a Wi-Fi assertion 
https://bugs.webkit.org/show_bug.cgi?id=185983
Summary [Wi-Fi Assertions] Track whether WiFiAssertionHolder should actually hold a W...
Andy Estes
Reported 2018-05-25 09:25:21 PDT
[Wi-Fi Assertions] Track whether WiFiAssertionHolder should actually hold a Wi-Fi assertion
Attachments
Patch (13.21 KB, patch)
2018-05-25 09:28 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2018-05-25 09:28:02 PDT
Created attachment 341293 [details] Patch
Andy Estes
Comment 2 2018-05-25 09:28:16 PDT
rdar://problem/40205486
Tim Horton
Comment 3 2018-05-28 23:26:21 PDT
Comment on attachment 341293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341293&action=review > Source/WebKit/NetworkProcess/cocoa/WiFiAssertionHolder.mm:48 > + holdWiFiAssertion(*this); Seems odd to call hold and release if shouldHold is false
WebKit Commit Bot
Comment 4 2018-05-29 17:47:06 PDT
Comment on attachment 341293 [details] Patch Clearing flags on attachment: 341293 Committed r232283: <https://trac.webkit.org/changeset/232283>
WebKit Commit Bot
Comment 5 2018-05-29 17:47:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.