Bug 185983 - [Wi-Fi Assertions] Track whether WiFiAssertionHolder should actually hold a Wi-Fi assertion
Summary: [Wi-Fi Assertions] Track whether WiFiAssertionHolder should actually hold a W...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-25 09:25 PDT by Andy Estes
Modified: 2018-05-29 17:47 PDT (History)
8 users (show)

See Also:


Attachments
Patch (13.21 KB, patch)
2018-05-25 09:28 PDT, Andy Estes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2018-05-25 09:25:21 PDT
[Wi-Fi Assertions] Track whether WiFiAssertionHolder should actually hold a Wi-Fi assertion
Comment 1 Andy Estes 2018-05-25 09:28:02 PDT
Created attachment 341293 [details]
Patch
Comment 2 Andy Estes 2018-05-25 09:28:16 PDT
rdar://problem/40205486
Comment 3 Tim Horton 2018-05-28 23:26:21 PDT
Comment on attachment 341293 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341293&action=review

> Source/WebKit/NetworkProcess/cocoa/WiFiAssertionHolder.mm:48
> +    holdWiFiAssertion(*this);

Seems odd to call hold and release if shouldHold is false
Comment 4 WebKit Commit Bot 2018-05-29 17:47:06 PDT
Comment on attachment 341293 [details]
Patch

Clearing flags on attachment: 341293

Committed r232283: <https://trac.webkit.org/changeset/232283>
Comment 5 WebKit Commit Bot 2018-05-29 17:47:07 PDT
All reviewed patches have been landed.  Closing bug.