ToT debug builds are crashing when compiling 1Blocker due to an assertion failure in DFANode::setActions.
<rdar://problem/39669458>
Created attachment 341430 [details] Patch
Comment on attachment 341430 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341430&action=review > LayoutTests/http/tests/contentextensions/root-actions-expected.txt:2 > +layer at (0,0) size 800x600 I do not see the need for this test to dump the render tree. It seems sufficient to make this a text-only trust. See my remark below on how to achieve this. > LayoutTests/http/tests/contentextensions/root-actions.html:1 > +<body> Unless it is necessary to use quirks mode for this test please add <!DOCTYPE html> at the top of this file and make this a well defined HTML document with <html> and </html>. Please make this a text-only test as opposed to a render tree dump. You can do this by adding the following markup to the <head> or <body>: <script> if (window.testRunner) testRunner.dumpAsText(); </script>
Created attachment 341449 [details] Patch
Comment on attachment 341449 [details] Patch r=me
Comment on attachment 341449 [details] Patch cq+
Comment on attachment 341449 [details] Patch Clearing flags on attachment: 341449 Committed r232265: <https://trac.webkit.org/changeset/232265>
All reviewed patches have been landed. Closing bug.