RESOLVED FIXED 185973
ProcessLauncherMac.mm contains a couple of meaningless #ifndef directives 
https://bugs.webkit.org/show_bug.cgi?id=185973
Summary ProcessLauncherMac.mm contains a couple of meaningless #ifndef directives
mitz
Reported 2018-05-24 22:01:36 PDT
#ifndef _NDEBUG is always true because no configuration ever defines _NDEBUG. Patch forthcoming.
Attachments
Use #if !ASSERT_DISABLED instead (1.91 KB, patch)
2018-05-24 22:03 PDT, mitz 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2018-05-24 22:03:43 PDT
Created attachment 341252 [details] Use #if !ASSERT_DISABLED instead
mitz
Comment 2 2018-05-24 22:09:47 PDT
Fixed in <https://trac.webkit.org/r232184>.
Radar WebKit Bug Importer
Comment 3 2018-05-24 22:10:18 PDT
<rdar://problem/40546223>
Darin Adler
Comment 4 2018-05-25 21:26:28 PDT
Glad you took care of this. I was planning to ask how _NDEBUG was getting set after spotting it in a patch.
Note You need to log in before you can comment on or make changes to this bug.