Bug 185966 – [iOS] Avoid dlopening QuickLooks in the common case where the main resource is HTML or plain text

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Chris Dumez]

Avoid dlopening QuickLooks in the common case where the main resource is HTML or plain text:
Sample Count, Samples %, CPU %, Symbol
33, 0.3%, 0.2%, void IPC::handleMessage<Messages::WebResourceLoader::DidReceiveResponse, WebKit::WebResourceLoader, void (WebKit::WebResourceLoader::*)(WebCore::ResourceResponse const&, bool)>(IPC::Decoder&, WebKit::WebResourceLoader*, void (WebKit::WebResourceLoader::*)(WebCore::ResourceResponse const&, bool)) (in WebKit)
33, 0.3%, 0.2%,     WebKit::WebResourceLoader::didReceiveResponse(WebCore::ResourceResponse const&, bool) (in WebKit)
32, 0.3%, 0.2%,         WebCore::SubresourceLoader::didReceiveResponse(WebCore::ResourceResponse const&, WTF::CompletionHandler<void ()>&&) (in WebCore)
26, 0.2%, 0.1%,             WebCore::PreviewLoader::shouldCreateForMIMEType(WTF::String const&) (in WebCore)
26, 0.2%, 0.1%,                 std::__1::__call_once(unsigned long volatile&, void*, void (*)(void*)) (in libc++.1.dylib)
26, 0.2%, 0.1%,                     void std::__1::__call_once_proxy<std::__1::tuple<WebCore::PreviewLoader::shouldCreateForMIMEType(WTF::String const&)::$_2&&> >(void*) (in WebCore)
26, 0.2%, 0.1%,                         WebCore::QLPreviewGetSupportedMIMETypesSet() (in WebCore)
26, 0.2%, 0.1%,                             WebCore::initQuickLookQLPreviewGetSupportedMIMETypes() (in WebCore)
26, 0.2%, 0.1%,                                 dispatch_once_f$VARIANT$mp (in libdispatch.dylib)
26, 0.2%, 0.1%,                                     _dispatch_client_callout (in libdispatch.dylib)
26, 0.2%, 0.1%,                                         invocation function for block in WebCore::initQuickLookQLPreviewGetSupportedMIMETypes() (in WebCore)
26, 0.2%, 0.1%,                                             dispatch_once_f$VARIANT$mp (in libdispatch.dylib)
26, 0.2%, 0.1%,                                                 _dispatch_client_callout (in libdispatch.dylib)
26, 0.2%, 0.1%,                                                     invocation function for block in WebCore::QuickLookLibrary(bool) (in WebCore)
26, 0.2%, 0.1%,                                                         dlopen (in libdyld.dylib)
26, 0.2%, 0.1%,                                                             dlopen_internal (in dyld)

[Chris Dumez]

Created attachment 341233 [details]
Patch

[Geoffrey Garen]

Comment on attachment 341233 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 341233 [details]
Patch

Clearing flags on attachment: 341233

Committed r232179: <https://trac.webkit.org/changeset/232179>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/40542935>