Bug 18596 – Google Docs do not compare in Safari (5874511)

• Status: RESOLVED
• Resolution: CONFIGURATION CHANGED
• Component: Evangelism

[Kevin McCullough]

This bug was reported to me, but I have been unable to reproduce it and wanted to keep track of it and see if anyone else had experienced it.

Steps To Reproduce:
1.  Create a Googe Docs document.
2.  Make sevral revsions over time.  You can force this by saving between edits/entrie.
3.  Share the doc with another GOOG account
4.  Edit the doc from that other account, make sevral revisions as above.
5.  From either account get into Revision History
6.  Check two revisions and Compare Checked/

[Kevin McCullough]

related to https://bugs.webkit.org/show_bug.cgi?id=18598

[Kevin McCullough]

I believe what is going on is that Google Docs is adding a <style> tag to an element in the body of the document.  This is not legal in HTML 4 and each browser handles it differently.  Currently we copy any <style> tags into the head during parsing, but if they are added after parsing we will miss them.  I believe this is what is happening.

The simplest solution would be for Google Docs to add the <style> element to the head and not within the body.

Also I found a workaround to this issue.  To get to the Revision History you can either click on the document you wish to view, then choose the JS File menu, then click Revision History, then choose your revisions, or you can right-click on the document you wish to view, then choose Revisions, then choose the revisions you wish to compare.  In the first set of steps the bug will happen, in the second it will not and the highlighting will happen correctly.

[Kevin McCullough]

Created attachment 20783 [details]
Test that adds a <style> element to the head.

[Kevin McCullough]

Created attachment 20784 [details]
Test that adds a <style> element to the body.

[Ojan Vafai]

Why not fix this in Safari? While it may be illegal according to the spec and browsers may do different things, Safari is the only one that breaks here, right?

[Dave Hyatt]

Yes, the bugs are filed and we plan to fix them, but the assumption is that you might want to work around the problem.  Putting styles in the head will perform better even in browsers that support programmatic insertion of styles anywhere.  Basically it's poor coding practice to put styles all over your body.  If you don't care that's fine, but it's still sloppy coding to do it.

https://bugs.webkit.org/show_bug.cgi?id=5476
https://bugs.webkit.org/show_bug.cgi?id=5478

[David Kilzer (:ddkilzer)]

See also:

https://bugs.webkit.org/show_bug.cgi?id=11397