Bug 185955 - REGRESSION(r224908): [macOS] Media playback not honoring custom caption styles
Summary: REGRESSION(r224908): [macOS] Media playback not honoring custom caption styles
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on: 179747
Blocks:
  Show dependency tree / graph
 
Reported: 2018-05-24 12:46 PDT by Brent Fulgham
Modified: 2018-05-24 13:33 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.79 KB, patch)
2018-05-24 12:52 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2018-05-24 12:46:54 PDT 
In Bug 179747 I removed access to the MediaAccessibility mach port, as well as read/write access to various preferences associated with that process, as it was no longer needed by modern WebKit media routines.

Detailed testing reveals that read access is still needed to these preferences to properly handle custom caption styles.

This patch re-enables access to the media accessibility preferences.
Comment 1 Brent Fulgham 2018-05-24 12:48:17 PDT 
<rdar://problem/40339278>
Comment 2 Brent Fulgham 2018-05-24 12:52:09 PDT 
Created attachment 341217 [details]
Patch
Comment 3 WebKit Commit Bot 2018-05-24 13:33:23 PDT 
Comment on attachment 341217 [details]
Patch

Clearing flags on attachment: 341217

Committed r232162: <https://trac.webkit.org/changeset/232162>
Comment 4 WebKit Commit Bot 2018-05-24 13:33:24 PDT 
All reviewed patches have been landed.  Closing bug.