Upgrade test262 to May 24 version
Created attachment 341173 [details] Patch
Attachment 341173 [details] did not pass style-queue: ERROR: Unexpected diff format when parsing a chunk: '", "");' ERROR: Unexpected diff format when parsing a chunk: "', '');" ERROR: JSTests/test262/test/language/literals/string/line-continuation-double.js:59: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1] ERROR: Suppressing further [whitespace/carriage_return] reports for this file. ERROR: JSTests/test262/test/language/literals/string/line-continuation-single.js:59: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1] ERROR: Suppressing further [whitespace/carriage_return] reports for this file. Total errors found: 2 in 265 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 341173 [details] Patch rs=me
Committed r232224: <https://trac.webkit.org/changeset/232224>
<rdar://problem/40577943>
The "Debug Tests262 (Tests)" bot started failing after this commit: <https://build.webkit.org/builders/Apple%20Sierra%20Debug%20Test262%20(Tests)?numbuilds=50> I wonder if the new test suite is taking too long, or whether one of the tests is now hanging?
(In reply to David Kilzer (:ddkilzer) from comment #6) > The "Debug Tests262 (Tests)" bot started failing after this commit: > > <https://build.webkit.org/builders/ > Apple%20Sierra%20Debug%20Test262%20(Tests)?numbuilds=50> > > I wonder if the new test suite is taking too long, or whether one of the > tests is now hanging? The "Release Test262 (Tests)" bot is doing fine, though: <https://build.webkit.org/builders/Apple%20Sierra%20Release%20Test262%20(Tests)?numbuilds=50>
(In reply to David Kilzer (:ddkilzer) from comment #6) > The "Debug Tests262 (Tests)" bot started failing after this commit: > > <https://build.webkit.org/builders/ > Apple%20Sierra%20Debug%20Test262%20(Tests)?numbuilds=50> > > I wonder if the new test suite is taking too long, or whether one of the > tests is now hanging? Can we know what test is hanging / slow from the buildbot log?
We should be able to capture a better report with the changes from Bug 186115
(In reply to Leo Balter from comment #9) > We should be able to capture a better report with the changes from Bug 186115 And I think we should have timeout for each test. we can do that by setting environment variable "JSCTEST_timeout".
> And I think we should have timeout for each test. we can do that by setting environment variable "JSCTEST_timeout". The t262 runner already accepts a --timeout=<ms number> option that relies on the jsc --watchdog. The main problem here is finding a proper timeout option for the tests. Some of them are slow, but in my dedicated machine none will go over 20 seconds. Maybe I should also include the execution time for each test in the verbose mode? We already have this in the generated results file.
It seems that bot becomes fine with logging. Closing this bug.