RESOLVED FIXED 185935
Use ASCIILiteral with applicationBundleIsEqualTo in RuntimeApplicationChecksCocoa 
https://bugs.webkit.org/show_bug.cgi?id=185935
Summary Use ASCIILiteral with applicationBundleIsEqualTo in RuntimeApplicationChecksC...
Joseph Pecoraro
Reported 2018-05-23 21:25:35 PDT
Use ASCIILiteral with applicationBundleIsEqualTo in RuntimeApplicationChecksCocoa. All of these convert a string literal into a WTFString.
Attachments
[PATCH] Proposed Fix (9.83 KB, patch)
2018-05-23 21:26 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2018-05-23 21:26:23 PDT
Created attachment 341169 [details] [PATCH] Proposed Fix
Yusuke Suzuki
Comment 2 2018-05-23 22:14:38 PDT
Comment on attachment 341169 [details] [PATCH] Proposed Fix r=me
WebKit Commit Bot
Comment 3 2018-05-23 22:42:15 PDT
Comment on attachment 341169 [details] [PATCH] Proposed Fix Clearing flags on attachment: 341169 Committed r232148: <https://trac.webkit.org/changeset/232148>
WebKit Commit Bot
Comment 4 2018-05-23 22:42:16 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-05-23 22:43:20 PDT
<rdar://problem/40511274>
Darin Adler
Comment 6 2018-05-25 21:19:14 PDT
Can’t we make the function take a const char* instead? Why make a WTF::String at all?
Joseph Pecoraro
Comment 7 2018-05-25 21:36:10 PDT
(In reply to Darin Adler from comment #6) > Can’t we make the function take a const char* instead? Why make a > WTF::String at all? I'd be fine with that too. In this case either would work just fine.
Darin Adler
Comment 8 2018-05-25 21:45:47 PDT
(In reply to Joseph Pecoraro from comment #7) > (In reply to Darin Adler from comment #6) > > Can’t we make the function take a const char* instead? Why make a > > WTF::String at all? > > I'd be fine with that too. In this case either would work just fine. We should definitely do that. There is no reason to create and destroy a String when these functions are called. On the other hand, the work is only done the first time each is called, so it’s a tiny efficiency.
Note You need to log in before you can comment on or make changes to this bug.